chore(LocationComponent): provide convenience constructor for Vector3i #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: prefer set() over new instances in copyFrom()
chore: prefer set over new instance in copyFrom
keturn
added
the
Size: S
github-actions
bot
added
the
Type: Chore
pollend
reviewed
Sep 11, 2021
| @@ -35,7 +36,7 @@ | |||
| // Standard position/rotation | |||
| @Replicate | |||
| @TextField | |||
| Vector3f position = new Vector3f(); | |||
| final Vector3f position = new Vector3f(); | |||
There was a problem hiding this comment.
I don't think you can have this as final. how does the serialization work in gestalt, I thought it instantiated a new object and assigned it but you can't do that if the field is final.
|
umm looks like it seem to work fine in multiplayer? |
pollend
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: prefer set() over new instances in copyFrom()