Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade minimum compatible version to Java 11 #4928

Merged
merged 6 commits into from
Nov 7, 2021

Conversation

keturn
Copy link
Member

@keturn keturn commented Oct 16, 2021

This updates the project's gradle configuration to use the Java 11 compatibility level. IntelliJ IDEA will recognize this configuration when determining which languages features are available.

Requires

@github-actions github-actions bot added the Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. label Oct 16, 2021
@keturn
Copy link
Member Author

keturn commented Oct 16, 2021

Java Version

@keturn
Copy link
Member Author

keturn commented Nov 1, 2021

Build passed its unit tests, but crashed during the javadoc task? That's certainly not what I expected. Maybe I didn't put enough RAM in the pod configuration?

(Yet unknown if integration tests pass, because that stage only runs after javadoc completes.)

@keturn
Copy link
Member Author

keturn commented Nov 1, 2021

  • CI test run 4: re-build with the same configuration. Failed in an earlier stage.
  • CI test run 5: increased pod memory limit to 6Gi, matching the old java8 precached pod configuration. Build succeeded.

@keturn
Copy link
Member Author

keturn commented Nov 1, 2021

The LGTM service has a Java 8 build environment.

There's been no news posted to their blog since they were acquired by GitHub two years ago.
I can't connect to their discourse forum.

Would we be okay with dropping the LGTM GitHub integration?

🔗 Discord Thread

jdrueckert
jdrueckert previously approved these changes Nov 5, 2021
@keturn
Copy link
Member Author

keturn commented Nov 5, 2021

I really expected to run in to the #3992 failure at this point, but it looks like all the tests are passing in this run, so hooray?

@keturn
Copy link
Member Author

keturn commented Nov 5, 2021

wait, I do get that failure locally. 😕

@keturn
Copy link
Member Author

keturn commented Nov 5, 2021

I think we have not been running the TypeHandlerLibrary tests ever since the unitTest / integrationTest split 😢

@keturn keturn merged commit a41da96 into develop Nov 7, 2021
@keturn keturn deleted the build/java11minimum branch November 7, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants