Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: parametrize logger usages #5173

Merged
merged 14 commits into from
Nov 19, 2023
Merged

qa: parametrize logger usages #5173

merged 14 commits into from
Nov 19, 2023

Commits on Nov 14, 2023

  1. qa: parametrize logger usages

    @jdrueckert
    jdrueckert committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f70b5d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. build: upgrade slf4j-2.0, permit passing suppliers to loggers (lazy e… 

    …valuation) (#5174)

permit use of slf4j fluent api:
https://www.slf4j.org/manual.html#fluent

tried to upgrade to logback 1.3.x or logback 1.4.x, but code contains
code depending on ch.qos.logback.core.joran.spi.InterpretationContext:
engine/src/main/java/org/terasology/logback/RegexFilterAction.java

for engine tests though, an upgrade was necessary as the code uses
logback-classic directly.
    @soloturn
    soloturn committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    39da317 View commit details
    Browse the repository at this point in the history

  2. chore: remove superfluous toString() calls 

    Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
    @jdrueckert @skaldarnar
    jdrueckert and skaldarnar committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9076613 View commit details
    Browse the repository at this point in the history

  3. chore: remove superfluous toString calls

    @jdrueckert
    jdrueckert committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f6f1ad5 View commit details
    Browse the repository at this point in the history

  4. chore: reuse existing local variables in log

    @jdrueckert
    jdrueckert committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d1e3677 View commit details
    Browse the repository at this point in the history

  5. refactor: introduce new local variable to use in logic and logs

    @jdrueckert
    jdrueckert committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2d02c21 View commit details
    Browse the repository at this point in the history

  6. refactor: parametrize log

    @jdrueckert
    jdrueckert committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    75c9521 View commit details
    Browse the repository at this point in the history

  7. chore: fix minor typos in comment

    @jdrueckert
    jdrueckert committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9202869 View commit details
    Browse the repository at this point in the history

  8. chore: log full exception instead of only exception message

    @jdrueckert
    jdrueckert committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e2fa44e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Merge branch 'develop' into qa/logger

    @jdrueckert
    jdrueckert committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    e76f9d5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into qa/logger

    @jdrueckert
    jdrueckert committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    28b87ac View commit details
    Browse the repository at this point in the history

  3. ci: retrigger

    @jdrueckert
    jdrueckert committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    26cd0ea View commit details
    Browse the repository at this point in the history

  4. fix: variable scope

    @jdrueckert
    jdrueckert committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    f9b8e44 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Merge branch 'develop' into qa/logger

    @jdrueckert
    jdrueckert committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    b168c19 View commit details
    Browse the repository at this point in the history