qa: parametrize logger usages

[jdrueckert]

Re-does #5173 (reverting its revert #5180)

[jdrueckert]

@soloturn let's split out the slf4j upgrade and any lazy log adjustments
thus, the remaining changes can be merged until we get the slf4j upgrade to work

[soloturn]

how do you want me to get a commit in here? like this #5182 ?

[jdrueckert]

how do you want me to get a commit in here? like this #5182 ?

you should have permissions to work on branches on the original repo, not your fork 🤔
this should also allow you to checkout and commit on an existing branch...

if this is not the case, please tell me so I can recheck your permissions

the idea would be to remove the slf4j upgrade from this branch and open a new PR (targeting develop) with the removed changes

[soloturn]

no right

❯ git push
ERROR: Permission to MovingBlocks/Terasology.git denied to soloturn.
fatal: Could not read from remote repository.

[jdrueckert]

@soloturn you should've received an invitation to the ReviverWriteAccess GitHub team
Becoming a member of that team provides you with privileges to push branches and commits to the MovingBlocks/Terasology and MovingBlocks/TeraConfig repos as well as manage issues and PRs.

[soloturn]

redone, there is one line less than in the original, failing one. engine/build.gradle stays on slf4j-1.7.36, @jdrueckert. for details see 7f4e40f and #5182.

[jdrueckert]

@soloturn why are we removing this here?

[jdrueckert]

only saw your comment now...

tested, and it is indeed not even used. so remove. also reverted back jul-to-slf4j.

so you're saying we don't use slf4j for our test stuff? interesting... what's used for logging in tests instead then? 🤔
I thought I saw logs in some tests, but maybe I misremember?

[soloturn]

slf4j comes into engine-tests via engine whose version wins. a lot of tohers bring slf4j in differing version as well, like gestalt, jnbullet, nui, nui-reflect, nui-gestatl, etc etc says gralde -q dependencies in folder engine-tests, in both compile and runtime classpath. i will be more explicit in the commit comment next time, @jdrueckert .

[BenjaminAmos]

These changes look mostly stylistic rather than functional. The dependency upgrades seem minor and ideally shouldn't break anything. There shouldn't be much harm in merging this now.