This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Add scaffolding to keep track of the source page for any payment journey #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
suggested changes
Aug 5, 2019
There was a problem hiding this comment.
@solarissmoke I would suggest using forms.IntegerField() in the payment forms and not worrying about continually validating the value. It seems like we only need to worry about linking the value up to a page in get_source_page() and at that point we can filter the queryset as necessary.
solarissmoke
force-pushed
the
feature/track-source-page
branch
from
8eda09b
to
717d76a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the ID of the originating page in the session at the end of a transaction. This will be used to gather data required for #27.
Also added some missing tests for
get_transaction_details_for_sessionfor single/monthly card views.