Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fellowship mini site] Cropped hero image (responsive view) #1124

Closed
taisdesouzalessa opened this issue Mar 1, 2018 · 2 comments
Closed
Assignees

Comments

@taisdesouzalessa
Copy link
Contributor

taisdesouzalessa commented Mar 1, 2018

Issue

In some views of the site, the hero image is cropped:
image

@mmmavis I wonder if we could have a fix for that. It is not urgent, you and I could work together to figure out viable alternatives to this issue later on, what do you think?

@xmatthewx tagging you here to capture your thoughts on it as well :)

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 1, 2018

I can write some custom CSS to make this look better.

It's very hard to have this gradient + line art + photo hero banner look good on all screen sizes without adding a ton of dirty CSS code. The horizontal lines and photo combo is making this troublesome to implementation. (just a note for future reference)

mmmavis added a commit that referenced this issue Mar 1, 2018
mmmavis added a commit that referenced this issue Mar 1, 2018
* Related to #1120 - updated fellowships homepage content and layout again
* Related to #1124 - hero banner adjustment
@mmmavis
Copy link
Collaborator

mmmavis commented Mar 1, 2018

Fixed.

@mmmavis mmmavis closed this as completed Mar 1, 2018
mmmavis added a commit that referenced this issue Mar 6, 2018
* Set stage for fellowships pages w/ django template (#961)

* Set stage for fellowships pages w/ django template

* Adding some stub urls for the fellowships site. (#971)

* Adding some stub urls for the fellowships site.

* Update some of the urls a bit more

* fellowships homepage wireframe (#965)

* Fix review apps for fellows (#1010)

* Test commit

* Find out which url is it resolving to

* Fix stuff

* Remove debugging stuff

* fixed rebase conflicts

* Fellowships support page (#1006)

Fellowships support page

* fixed rebase conflicts

* Responsive fellowships nav & better multi-page nav on mobile (#1020)

* Related to #1019 - repsonsive fellowships nav + #977 - better multi-page nav on mobile

* Updated fellowships homepage (#1042)

* updated fellowships homepage

* updated fellowships support page (#1049)

* Fellowships directory pages (#1046)

* Related to #955 - fellowships directory pages

* Update fellowships type pages (#1059)

* added illustration to fellowship types page and fellowships support page (#1061)

* made fellowships work use the new master template (#1069)

* updated /apply page so it's in 'application open' state (#1070)

* More assets (#1073)

* added more assets & created a svg sub-folder

* added hero image to fellowships homepage

* Related to #1062 - hide affiliation meta from front end (#1075)

* design tweaks (#1081)

* design tweaks

* show fellow location in fellowships directory (#1103)

* Added loading icon (#1093)

* Related to #1045 - added loading icon

* Featured fellows (#1112)

* added featured fellows on fellowships homehomepomepage (hardcoded)

* hide some incomplete content for now (#1113)

* Fixes #1092 - added back missing icon & ran task to optimize svgs (#1108)

* Added placeholder headshot to Person component (#1119)

* Related #1114 - added placeholder headshot

* Updated fellowships homepage content and layout again (#1122)

* Related to #1120 - updated fellowships homepage content and layout again
* Related to #1124 - hero banner adjustment

* Fixed #1096 - replaced a svg (#1123)

* Content changes to apply page (#1127)

* Related to #1116 - content changes to apply page

* Fixed broken 'see work' link (#1129)

* Fixed #1128 - fixed broken 'see work' link

* Fixes #1144 - fixed a fellow's social link (#1145)

* remmoved 'senior fellow' section from directory pages (#1150)

* redirected /fellowship to /fellowships (#1149)

* redirected /fellowship to /fellowships

* removed an extra line

* Fellowships improvements (#1157)

* code improvement

* removed a few empty files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants