Added loading icon #1093
Added loading icon #1093
Conversation
|
@xmatthewx will this icon work? If not I can change it to what we have on Pulse. https://foundation-mofostaging-pr-1093.herokuapp.com/fellowships/directory/
|
|
Looks good! |
mmmavis
force-pushed
the
issue-1045-loading-icon
branch
from
d2efb88
to
24687b7
Compare
|
It feels like this could be done in a much simpler way with a single SVG asset animated with CSS. Is there some reason it's built like this? 🤔 |
|
@gvn slide 5 is what we were hoping to achieve but we didn't have the time to get the "scaling dots" to work... that's why we are going with a simpler version (for now). I'm fine with either sticking with this pure CSS version or SVG (3 dots on circle) w/ CSS for animation. @gvn you prefer the latter? If so, I will ask @taisdesouzalessa to create the SVG. |
|
Ok, that makes more sense. I'd say keep this if we plan on adding the dot animations later, but if we're not then go to just a single SVG rotated w. CSS. |
|
@gvn coooool. yea let's keep this then. Now it's code review time for you 👀 |
| @@ -13,3 +13,4 @@ parserOptions: | |||
|
|
|||
| rules: | |||
| react/jsx-uses-vars: [2] | |||
| react/jsx-uses-react: [2] | |||
There was a problem hiding this comment.
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-react.md
without this source/js/components/loading-indicator/loading-indicator.jsx will throw a linting error
|
☕️ 🍰 |
* Set stage for fellowships pages w/ django template (#961) * Set stage for fellowships pages w/ django template * Adding some stub urls for the fellowships site. (#971) * Adding some stub urls for the fellowships site. * Update some of the urls a bit more * fellowships homepage wireframe (#965) * Fix review apps for fellows (#1010) * Test commit * Find out which url is it resolving to * Fix stuff * Remove debugging stuff * fixed rebase conflicts * Fellowships support page (#1006) Fellowships support page * fixed rebase conflicts * Responsive fellowships nav & better multi-page nav on mobile (#1020) * Related to #1019 - repsonsive fellowships nav + #977 - better multi-page nav on mobile * Updated fellowships homepage (#1042) * updated fellowships homepage * updated fellowships support page (#1049) * Fellowships directory pages (#1046) * Related to #955 - fellowships directory pages * Update fellowships type pages (#1059) * added illustration to fellowship types page and fellowships support page (#1061) * made fellowships work use the new master template (#1069) * updated /apply page so it's in 'application open' state (#1070) * More assets (#1073) * added more assets & created a svg sub-folder * added hero image to fellowships homepage * Related to #1062 - hide affiliation meta from front end (#1075) * design tweaks (#1081) * design tweaks * show fellow location in fellowships directory (#1103) * Added loading icon (#1093) * Related to #1045 - added loading icon * Featured fellows (#1112) * added featured fellows on fellowships homehomepomepage (hardcoded) * hide some incomplete content for now (#1113) * Fixes #1092 - added back missing icon & ran task to optimize svgs (#1108) * Added placeholder headshot to Person component (#1119) * Related #1114 - added placeholder headshot * Updated fellowships homepage content and layout again (#1122) * Related to #1120 - updated fellowships homepage content and layout again * Related to #1124 - hero banner adjustment * Fixed #1096 - replaced a svg (#1123) * Content changes to apply page (#1127) * Related to #1116 - content changes to apply page * Fixed broken 'see work' link (#1129) * Fixed #1128 - fixed broken 'see work' link * Fixes #1144 - fixed a fellow's social link (#1145) * remmoved 'senior fellow' section from directory pages (#1150) * redirected /fellowship to /fellowships (#1149) * redirected /fellowship to /fellowships * removed an extra line * Fellowships improvements (#1157) * code improvement * removed a few empty files
Related to #1045