Fellowships directory pages #1046

mmmavis · 2018-02-09T19:34:47Z

Related to #955

latest Sketch file: https://drive.google.com/drive/folders/13B0EMMavSNsibacHIpJd1sMi9TvslR7o (v2 one)
feel free to create some fake profiles on Pulse API staging for testing: https://pulse-api.mofostaging.net/admin/profiles/userprofile/
[to be fixed] API currently doesn't return location and profile id info. That's why the location field and "see work" link in the <Person> cards don't work as expected.

e.g.,

🔷 https://foundation-mofostaging-pr-1046.herokuapp.com/fellowships/directory/

this page shows all 2017 fellows

🔷 https://foundation-mofostaging-pr-1046.herokuapp.com/fellowships/directory/<program_type>

shows all fellows on that program
fellows are grouped by program year
e.g., https://foundation-mofostaging-pr-1046.herokuapp.com/fellowships/directory/senior

mmmavis · 2018-02-09T19:54:13Z

@alanmoo assigned this one to your for review since you were already checking out this directory page work earlier

alanmoo · 2018-02-09T20:44:39Z

source/js/main.js

@@ -23,13 +23,14 @@ import fellowships from './fellowships';
 const SHOW_MEMBER_NOTICE = false;

 // To be populated via XHR...
-let env, networkSiteURL;
+let env, networkSiteURL, pulseApiURL;



Is this going to cause problems when promoting heroku pipelines?

Oh or is it pulling this from the environment json view that the server exposes?

@alanmoo I think it should be fine. I'm following exactly how we are doing to get networkSiteURL from the env var NETWORK_SITE_URL (from environment json).

alanmoo · 2018-02-09T20:55:58Z

network-api/networkapi/fellows/urls.py

    url(r'^directory/$',
        views.fellows_directory,
        name='fellowships-directory'),
+    url(r'^directory/senior$',


I know we're doing things pretty statically, but I think it's worth it to make this DRYer. Check out named groups

alanmoo · 2018-02-09T21:29:04Z

source/js/fellowships.js

+  req.send();
+}
+
+function renderFellowCard(fellow) {


Can you put a comment in describing what this is doing (vs, say, the existing person.jsx component)?

alanmoo

This is looking pretty good, a few smaller comments beyond DRYing out the view logic

alanmoo · 2018-02-09T21:38:19Z

source/js/fellowships.js

+    </button>;
+  };
+
+  getFellows({'program_year': `2017`}, fellows => {


Let's make this a const at the top of the file so it stands out more when we want to change it

alanmoo · 2018-02-09T22:33:50Z

source/js/fellowships.js

+
+  getFellows({'program_year': `2017`}, fellows => {
+    let fellowsByType = groupFellowsByAttr(`program_type`, fellows);
+    const ORDER = [ `senior`, `science`, `open web`, `tech policy`, `media`];


Maybe bring this to the top while you're at it?

PR updated!

alanmoo · 2018-02-13T15:43:08Z

network-api/networkapi/fellows/urls.py

    url(r'^directory/$',
        views.fellows_directory,
        name='fellowships-directory'),
+    url(r'^directory/(?P<program_type_slug>[-\w]+)/$',
+        views.fellows_directoy_type,
+        name='fellowships-directory-senior'),


Why is this called "senior"?

alanmoo · 2018-02-13T16:45:52Z

network-api/networkapi/templates/fellowships-base.html

@@ -80,7 +80,7 @@
          <div class="col">
            <div id="multipage-nav" class="d-flex flex-row align-items-center">
              <div><a href="{% url 'fellowships-home' %}" class="{% fellowship_active_nav request 'fellowships-home fellowships-science fellowships-open-web' %}">Fellowships</a></div>
-              <div><a href="{% url 'fellowships-directory' %}" class="{% fellowship_active_nav request 'fellowships-directory' %}">Directory</a></div>
+              <div><a href="{% url 'fellowships-directory' %}" class="{% fellowship_active_nav request 'fellowships-directory fellowships-directory-senior' %}">Directory</a></div>


Similar to above, I'm not clear on what the senior bit is doing here

alanmoo

A few comments above, but nothing serious. This looks pretty good considering where the API has been. Once we've polished the API, I think we can clean up a lot more of this to be a bit more content-agnostic.

PR updated

* Related to #955 - fellowships directory pages

* Set stage for fellowships pages w/ django template (#961) * Set stage for fellowships pages w/ django template * Adding some stub urls for the fellowships site. (#971) * Adding some stub urls for the fellowships site. * Update some of the urls a bit more * fellowships homepage wireframe (#965) * Fix review apps for fellows (#1010) * Test commit * Find out which url is it resolving to * Fix stuff * Remove debugging stuff * fixed rebase conflicts * Fellowships support page (#1006) Fellowships support page * fixed rebase conflicts * Responsive fellowships nav & better multi-page nav on mobile (#1020) * Related to #1019 - repsonsive fellowships nav + #977 - better multi-page nav on mobile * Updated fellowships homepage (#1042) * updated fellowships homepage * updated fellowships support page (#1049) * Fellowships directory pages (#1046) * Related to #955 - fellowships directory pages * Update fellowships type pages (#1059) * added illustration to fellowship types page and fellowships support page (#1061) * made fellowships work use the new master template (#1069) * updated /apply page so it's in 'application open' state (#1070) * More assets (#1073) * added more assets & created a svg sub-folder * added hero image to fellowships homepage * Related to #1062 - hide affiliation meta from front end (#1075) * design tweaks (#1081) * design tweaks * show fellow location in fellowships directory (#1103) * Added loading icon (#1093) * Related to #1045 - added loading icon * Featured fellows (#1112) * added featured fellows on fellowships homehomepomepage (hardcoded) * hide some incomplete content for now (#1113) * Fixes #1092 - added back missing icon & ran task to optimize svgs (#1108) * Added placeholder headshot to Person component (#1119) * Related #1114 - added placeholder headshot * Updated fellowships homepage content and layout again (#1122) * Related to #1120 - updated fellowships homepage content and layout again * Related to #1124 - hero banner adjustment * Fixed #1096 - replaced a svg (#1123) * Content changes to apply page (#1127) * Related to #1116 - content changes to apply page * Fixed broken 'see work' link (#1129) * Fixed #1128 - fixed broken 'see work' link * Fixes #1144 - fixed a fellow's social link (#1145) * remmoved 'senior fellow' section from directory pages (#1150) * redirected /fellowship to /fellowships (#1149) * redirected /fellowship to /fellowships * removed an extra line * Fellowships improvements (#1157) * code improvement * removed a few empty files

Related to #955 - fellowships directory pages

90ab058

mmmavis requested review from cadecairos, gideonthomas and gvn as code owners February 9, 2018 19:34

mmmavis removed request for gvn, cadecairos and gideonthomas February 9, 2018 19:34

cadecairos temporarily deployed to foundation-mofostaging-pr-1046 February 9, 2018 19:35 Inactive

mmmavis requested a review from alanmoo February 9, 2018 19:53

alanmoo reviewed Feb 9, 2018

View reviewed changes

alanmoo previously requested changes Feb 9, 2018

View reviewed changes

named group url pattern

1c7c78f

mmmavis temporarily deployed to foundation-mofostaging-pr-1046 February 10, 2018 01:16 Inactive

added some inline comment and moved a few lines of code up

ff98aca

mmmavis temporarily deployed to foundation-mofostaging-pr-1046 February 10, 2018 01:27 Inactive

mmmavis requested a review from alanmoo February 10, 2018 01:30

cadecairos temporarily deployed to foundation-mofostaging-pr-1046 February 12, 2018 21:30 Inactive

alanmoo reviewed Feb 13, 2018

View reviewed changes

alanmoo previously requested changes Feb 13, 2018

View reviewed changes

updated an url name

bff301d

mmmavis deployed to foundation-mofostaging-pr-1046 February 13, 2018 19:00 View deployment

mmmavis requested a review from alanmoo February 13, 2018 19:00

alanmoo approved these changes Feb 13, 2018

View reviewed changes

mmmavis merged commit 3456e4f into fellowships Feb 13, 2018

mmmavis deleted the fellowships-directory-pages branch February 15, 2018 02:38

mmmavis added a commit that referenced this pull request Feb 15, 2018

Fellowships directory pages (#1046)

fb2c446

* Related to #955 - fellowships directory pages

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fellowships directory pages #1046

Fellowships directory pages #1046

mmmavis commented Feb 9, 2018 •

edited

Loading

mmmavis commented Feb 9, 2018

alanmoo Feb 9, 2018

alanmoo Feb 9, 2018

mmmavis Feb 9, 2018 •

edited

Loading

alanmoo Feb 9, 2018

alanmoo Feb 9, 2018 •

edited

Loading

alanmoo left a comment

alanmoo Feb 9, 2018

alanmoo Feb 9, 2018

alanmoo Feb 13, 2018 •

edited

Loading

alanmoo Feb 13, 2018

alanmoo left a comment

Fellowships directory pages #1046

Fellowships directory pages #1046

Conversation

mmmavis commented Feb 9, 2018 • edited Loading

mmmavis commented Feb 9, 2018

alanmoo Feb 9, 2018

Choose a reason for hiding this comment

alanmoo Feb 9, 2018

Choose a reason for hiding this comment

mmmavis Feb 9, 2018 • edited Loading

Choose a reason for hiding this comment

alanmoo Feb 9, 2018

Choose a reason for hiding this comment

alanmoo Feb 9, 2018 • edited Loading

Choose a reason for hiding this comment

alanmoo left a comment

Choose a reason for hiding this comment

alanmoo Feb 9, 2018

Choose a reason for hiding this comment

alanmoo Feb 9, 2018

Choose a reason for hiding this comment

alanmoo Feb 13, 2018 • edited Loading

Choose a reason for hiding this comment

alanmoo Feb 13, 2018

Choose a reason for hiding this comment

alanmoo left a comment

Choose a reason for hiding this comment

mmmavis commented Feb 9, 2018 •

edited

Loading

mmmavis Feb 9, 2018 •

edited

Loading

alanmoo Feb 9, 2018 •

edited

Loading

alanmoo Feb 13, 2018 •

edited

Loading