Responsive fellowships nav & better multi-page nav on mobile #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age nav on mobile
mmmavis
requested review from
cadecairos,
gideonthomas and
gvn
as code owners
mmmavis
commented
Jan 31, 2018
| @@ -18,19 +18,30 @@ export default class MultipageNav extends React.Component { | |||
| } | |||
|
|
|||
| render() { | |||
| let activeLinkLabel; | |||
| let links = this.props.links.map((link, index) => { | |||
| let className = `opp-link${ link.isActive ? ` opp-link-active` : `` }`; | |||
There was a problem hiding this comment.
We should probably change all opp-link and opp-link-active class names to something more general like multipage-link and multipage-link-active. If this sounds sane let's tackle it in a follow-up ticket.
mmmavis
commented
Jan 31, 2018
| @@ -41,7 +41,7 @@ a { | |||
| line-height: 1.5; | |||
| } | |||
|
|
|||
| @mixin yellow-underline-nav-link($active-class-name, $font-family: "Zilla Slab") { | |||
| @mixin yellow-underline-nav-link($active-class-name, $font-family: "Nunito Sans") { | |||
There was a problem hiding this comment.
@taisdesouzalessa
This code change will make all multi-page nav links use Nunito Sans (which includes the links on the opportunity page). Sounds good? If not, I can revert opportunity page links back to Zilla Slab.
There was a problem hiding this comment.
That sounds good, Mavis. Since we will be using this style across pages, could we use Nunito Sans Semi Bold instead or the regular weight? So the element on the sidebar looks more like a menu and less like a body text. For all nav items - desktop and mobile. I'll alter the mockups to accommodate that change. Sounds good?
There was a problem hiding this comment.
Let's discuss this in a new ticket. From the style guide it seems like all the anchor styles are in bold (font-weight: 700). I hesitate to throw an exception there (at least not in this PR).
Will create a ticket and tag you @taisdesouzalessa and @gvn
gvn
approved these changes
Feb 1, 2018
| @@ -18,19 +18,30 @@ export default class MultipageNav extends React.Component { | |||
| } | |||
|
|
|||
| render() { | |||
| let activeLinkLabel; | |||
| let links = this.props.links.map((link, index) => { | |||
| let className = `opp-link${ link.isActive ? ` opp-link-active` : `` }`; | |||
|
🎉 🎉 🎉 |
mmmavis
added a commit
that referenced
this pull request
Feb 9, 2018
mmmavis
added a commit
that referenced
this pull request
Feb 9, 2018
mmmavis
added a commit
that referenced
this pull request
Feb 15, 2018
mmmavis
added a commit
that referenced
this pull request
Mar 6, 2018
* Set stage for fellowships pages w/ django template (#961) * Set stage for fellowships pages w/ django template * Adding some stub urls for the fellowships site. (#971) * Adding some stub urls for the fellowships site. * Update some of the urls a bit more * fellowships homepage wireframe (#965) * Fix review apps for fellows (#1010) * Test commit * Find out which url is it resolving to * Fix stuff * Remove debugging stuff * fixed rebase conflicts * Fellowships support page (#1006) Fellowships support page * fixed rebase conflicts * Responsive fellowships nav & better multi-page nav on mobile (#1020) * Related to #1019 - repsonsive fellowships nav + #977 - better multi-page nav on mobile * Updated fellowships homepage (#1042) * updated fellowships homepage * updated fellowships support page (#1049) * Fellowships directory pages (#1046) * Related to #955 - fellowships directory pages * Update fellowships type pages (#1059) * added illustration to fellowship types page and fellowships support page (#1061) * made fellowships work use the new master template (#1069) * updated /apply page so it's in 'application open' state (#1070) * More assets (#1073) * added more assets & created a svg sub-folder * added hero image to fellowships homepage * Related to #1062 - hide affiliation meta from front end (#1075) * design tweaks (#1081) * design tweaks * show fellow location in fellowships directory (#1103) * Added loading icon (#1093) * Related to #1045 - added loading icon * Featured fellows (#1112) * added featured fellows on fellowships homehomepomepage (hardcoded) * hide some incomplete content for now (#1113) * Fixes #1092 - added back missing icon & ran task to optimize svgs (#1108) * Added placeholder headshot to Person component (#1119) * Related #1114 - added placeholder headshot * Updated fellowships homepage content and layout again (#1122) * Related to #1120 - updated fellowships homepage content and layout again * Related to #1124 - hero banner adjustment * Fixed #1096 - replaced a svg (#1123) * Content changes to apply page (#1127) * Related to #1116 - content changes to apply page * Fixed broken 'see work' link (#1129) * Fixed #1128 - fixed broken 'see work' link * Fixes #1144 - fixed a fellow's social link (#1145) * remmoved 'senior fellow' section from directory pages (#1150) * redirected /fellowship to /fellowships (#1149) * redirected /fellowship to /fellowships * removed an extra line * Fellowships improvements (#1157) * code improvement * removed a few empty files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
#1019 - responsive fellowships nav
#977 - better multi-page nav on mobile
Proposed change: #977 (comment)