-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement People page #33
Comments
@gvn - two notes, in case you have questions:
|
@xmatthewx How do we determine featured cards? Do we look for a specific piece of data on that user (like a pull quote?) or a flag on the person that gets set? |
Scratch that, I see a "featured" boolean in the schema. |
People headshot images: #67 (comment) |
Also, is it OK to assume that the order of these people (specifically where the "featured") ones fall will be predetermined? Or should I build logic to divy up the placement of "featured" people? |
@xmatthewx See q's above ^ |
Hey @alanmoo, I can answer the first question you had about being poorly spaced. The "featured" cards will have more info (3 bullet points on one side and a quote on the other side). So all the white space will be filled in with bullet points or the quote (depending on the side of the card the user is in). Prototype: https://projects.invisionapp.com/share/ZJ9YTAGEA#/screens/216715363 |
I remember discussing sorting, but seems to have slipped through the cracks. @ldecoursy is our best single source for an opinion. Can we add a column to the spreadsheet? @alanmoo feel free to comment in spreadsheet if questions pop up on this content. Featured people should have a quote and more info in spreadsheet. If they don't have that, they don't get featured. Lastly, we want to emphasize members, not staff. Don't put staff toward the top. Hide some staff if it feels like we have too many. cc @hannahkane |
Actually I'm going to defer to @KevZawacki - my understanding is that editorial would drive who we might feature at the top of the page. So depending on what projects and news are being featured, we might adjust who appears at the top of the People page to reflect that work. Kevin, I'm happy to go over this with you if you can share the latest launch ed cal. |
@ldecoursy That makes sense. I can curate 'People' the same way I curate 'Projects.' Is there a spreadsheet that lists out all 'People' who will be available to feature? |
People are listed in various tabs here: https://docs.google.com/spreadsheets/d/1rwNFjojmnOHkctAIAin9Pd_rxziscGJBSWi-z2S6Bg4/edit#gid=866621792 Feel free to add a column to indicate things, maybe as high, med, low? We'll probably want some flexibility beyond editorial to balance things by member type, region, age, 'has partner logo', 'has quote'. Once you can do this via a CMS and preview, it'll be easier. Bright green indicates approval. You can ignore other entries. |
This is done, I created a follow up ticket for filling out the CMS. #146. Any other bugs/issues with people page should be opened in a new ticket. |
Depends on Profile Component #25
The text was updated successfully, but these errors were encountered: