Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement People page #33

Closed
xmatthewx opened this issue Jan 30, 2017 · 14 comments
Closed

Implement People page #33

xmatthewx opened this issue Jan 30, 2017 · 14 comments
Assignees
Milestone

Comments

@xmatthewx
Copy link
Contributor

Depends on Profile Component #25

@gvn
Copy link
Contributor

gvn commented Feb 13, 2017

@xmatthewx
Copy link
Contributor Author

@gvn -

two notes, in case you have questions:

  • some members have an affiliation with a partner org. You will see to two people in comp that have a logo below their pic. Fine to extend the height of the card. https://projects.invisionapp.com/share/ZJ9YTAGEA#/screens/216715363
  • some cards are featured. these have a big quote AND have a button to transition to more info. simple transition (fade?) is fine. mvp.

@alanmoo
Copy link
Contributor

alanmoo commented Mar 2, 2017

@xmatthewx How do we determine featured cards? Do we look for a specific piece of data on that user (like a pull quote?) or a flag on the person that gets set?

@alanmoo
Copy link
Contributor

alanmoo commented Mar 2, 2017

Scratch that, I see a "featured" boolean in the schema.

@sabrinang
Copy link

People headshot images: #67 (comment)

@hannahkane hannahkane removed this from the March 3, 2017 milestone Mar 6, 2017
@alanmoo
Copy link
Contributor

alanmoo commented Mar 6, 2017

Can I get some guidance on the featured people cards? Just expanding the content to 12 column feels a bit...poorly spaced.

image

@alanmoo
Copy link
Contributor

alanmoo commented Mar 6, 2017

Also, is it OK to assume that the order of these people (specifically where the "featured") ones fall will be predetermined? Or should I build logic to divy up the placement of "featured" people?

@gvn
Copy link
Contributor

gvn commented Mar 6, 2017

@xmatthewx See q's above ^

@taisdesouzalessa
Copy link
Contributor

taisdesouzalessa commented Mar 6, 2017

Hey @alanmoo, I can answer the first question you had about being poorly spaced. The "featured" cards will have more info (3 bullet points on one side and a quote on the other side). So all the white space will be filled in with bullet points or the quote (depending on the side of the card the user is in).

Example:
screen shot 2017-03-06 at 1 07 48 pm

Prototype: https://projects.invisionapp.com/share/ZJ9YTAGEA#/screens/216715363
If you click on Hera Hussain's "more details" you can see how the interaction works.

@xmatthewx
Copy link
Contributor Author

I remember discussing sorting, but seems to have slipped through the cracks. @ldecoursy is our best single source for an opinion. Can we add a column to the spreadsheet? @alanmoo feel free to comment in spreadsheet if questions pop up on this content.

Featured people should have a quote and more info in spreadsheet. If they don't have that, they don't get featured.

Lastly, we want to emphasize members, not staff. Don't put staff toward the top. Hide some staff if it feels like we have too many.

cc @hannahkane

@ldecoursy
Copy link

Actually I'm going to defer to @KevZawacki - my understanding is that editorial would drive who we might feature at the top of the page. So depending on what projects and news are being featured, we might adjust who appears at the top of the People page to reflect that work.

Kevin, I'm happy to go over this with you if you can share the latest launch ed cal.

@KevZawacki
Copy link

@ldecoursy That makes sense. I can curate 'People' the same way I curate 'Projects.'

Is there a spreadsheet that lists out all 'People' who will be available to feature?

@xmatthewx
Copy link
Contributor Author

People are listed in various tabs here: https://docs.google.com/spreadsheets/d/1rwNFjojmnOHkctAIAin9Pd_rxziscGJBSWi-z2S6Bg4/edit#gid=866621792

Feel free to add a column to indicate things, maybe as high, med, low? We'll probably want some flexibility beyond editorial to balance things by member type, region, age, 'has partner logo', 'has quote'. Once you can do this via a CMS and preview, it'll be easier.

Bright green indicates approval. You can ignore other entries.

@gvn gvn added the p0 label Mar 10, 2017
@hannahkane hannahkane modified the milestones: March 10, 2017, March 17 Mar 13, 2017
@alanmoo
Copy link
Contributor

alanmoo commented Mar 13, 2017

This is done, I created a follow up ticket for filling out the CMS. #146.

Any other bugs/issues with people page should be opened in a new ticket.

@alanmoo alanmoo closed this as completed Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants