Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI] Product page - header updates: Mozilla Researched #7377

Closed
4 tasks
Pomax opened this issue Sep 13, 2021 · 3 comments · Fixed by #7539
Closed
4 tasks

[PNI] Product page - header updates: Mozilla Researched #7377

Pomax opened this issue Sep 13, 2021 · 3 comments · Fixed by #7539
Assignees
Labels
Milestone

Comments

@Pomax
Copy link
Contributor

Pomax commented Sep 13, 2021

Relevant part of the updated product page comp:

image

Comps on figma: https://www.figma.com/proto/GwdoUiY4fzVyeLfXsAJGPq/*Privacy-Not-Included-Website?page-id=548%3A72128&node-id=611%3A77813&viewport=283%2C48%2C0.08&scaling=min-zoom&starting-point-node-id=611%3A77813

@danielfmiranda
Copy link
Collaborator

Hi @kristinashu! I have a quick question regarding this ticket and the medium-small breakpoints:

Currently, the new fields look good on both desktop and mobile breakpoints (The people voted section is just a placeholder for now):
Desktop:
Screen Shot 2021-09-27 at 12 18 11 PM
Mobile:
Screen Shot 2021-09-27 at 12 21 06 PM

However, on the medium and small breakpoints, the text seems to get very squished or compact:
Medium:
Screen Shot 2021-09-27 at 12 18 31 PM
Small:
Screen Shot 2021-09-27 at 12 18 48 PM

I was wondering if there was a way the design team would like us to resolve this. At the moment, one solution I can think of would be to have the columns go from 4 on desktop, to 2 and 2 on medium-small, and then finally to 1 on 1 on 1 on 1 on mobile.

However I wanted to run this by the design team to see if there were any other preferred solutions for this, thanks!

@kristinashu
Copy link

Thanks for checking @danielfmiranda! I think your suggestion of "columns go from 4 on desktop, to 2 and 2 on medium-small, and then finally to 1 on 1 on 1 on 1 on mobile" sounds good but I would like @sabrinang's input.

@sabrinang
Copy link

+1 @danielfmiranda your suggestion sounds good to me and I can see it looking like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants