Bkg img fix #35
Merged
Bkg img fix #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinenelson
reviewed
Jun 13, 2018
There was a problem hiding this comment.
Mentioning my review about checking in .DS_Store files here too.
|
@shinenelson will make sure this never happens in the future |
|
@shinenelson can i remove the .DS files directly from master without doing pull. |
|
|
Thank you for that. Can i do it in the morning. I am on my phone . |
|
Nobody is in a hurry here. 😉 (I took almost a month to come here to review these changes; even though I was not marked as a reviewer for these changes). This is not a critical bug in production that needs to be addressed immediately. Take your time. 👍 |
|
I have send you a mail regarding the portal. Can you look into it. |
|
Will do the removal tommorow itselfs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes ONLY. NO NEW FEATURE ACCEPTED!
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):