Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused search buttons in omnibox not really invisible #906

Closed
NebelNidas opened this issue Mar 21, 2019 · 2 comments
Closed

Unused search buttons in omnibox not really invisible #906

NebelNidas opened this issue Mar 21, 2019 · 2 comments

Comments

@NebelNidas
Copy link

NebelNidas commented Mar 21, 2019

Description
When Mozilla basically merged the URL bar with the search bar, they added the search engine buttons on the bottom. But they did it poorly - exactly like in the original search bar!
Cause there isn't a new button added for every new engine, the buttons are already there. For us users to not notice they made them invisible, but with a poor technique. If you have Add-Ons like GMF installed (as mentioned in #904 ), these buttons will become visible. Not really nice from a UX point of view.

To Reproduce
Steps to reproduce the behavior:

  1. Install GMF (caa:addon/glassmyfox)
  2. Check the "Buttons" checkbox
  3. Type something in the omnibox or search box

Expected behavior
These buttons should either be completely invisible or only be created when really needed.

Screenshots
Omnibox:
Waterfox omnibox buttons issue
Search Box:
Waterfox search box buttons issue

Desktop:

  • OS: Win7 x64
  • All Versions, I guess

Footnote
Just a small cosmetic flaw, but hey.

@laniakea64
Copy link

Does adding this to userChrome.css help? -

.searchbar-engine-one-off-item.dummy {
  visibility: hidden !important;
}

@NebelNidas
Copy link
Author

Yes, this works! Thanks! :D
However, I do think this should be set as default. Maybe Alex could implement it in the next release? Or would this break something with some other Add-On?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants