[Classic] Update user-agent overrides #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of a missing pref, a hard-coded value is still used from the ctor.
To respond dynamically to the pref change, the mAppVersion string needs to be rebuilt. Includes some minor improvements for corner cases and removes leftover b2g junk.
* Waterfox doesn't use separate name and version for engine * Change version * Allow to choose long or short version string
…ides More and more websites are closing the doors, so it's time to do that.
|
1st of all thank you for this change but there is something that came to my mind: Firefox now is at version 90 and somewhat close to 91, how long will this last till version 68 is considered outdated by those same sites? |
|
Well, 68 is well-tested by Moonchild, it's definitely better than 56. In the future maybe when more things will be ported, then maybe another bump would be good. |
|
Got it, thank you for the explanation, i hope 68 will last at least for a little bit. |
* Remove undefined variable and replace it with hardcoded Gecko version * Move version display variable, so it can be reused on other places
hawkeye116477
force-pushed
the
classic_ua
branch
from
c3bc564 to
3fd59aa
Compare
MrAlex94
approved these changes
Jul 30, 2021
|
It's approved, but not merged. What's the reason? |
I was traveling at the time, and lost Internet so could not approve until now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More and more websites are closing the doors for Classic with message like „Please update your browser", so I think that the best would be to do same like Moonchild did, so set 68.0 user-agent.
To make it more comfortable for the future to change compatibility version I borrowed code from Moonchild.
Now UA compatibility version can be read from pref (
general.useragent.compatMode.version). There is also possibility to toggle short/long Waterfox version string in user-agent (Waterfox 56.5.2021.07orWaterfox 2021.07).Default user-agent string looks like this:
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 Waterfox/56.5.2021.07.I also updated site specific user-agents (some have been removed, few changed, few added, borrowed from Pale Moon and Basilisk).