Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: full key compare #71

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix: full key compare #71

merged 1 commit into from
Mar 24, 2022

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Mar 24, 2022

user key and timestamp are supposed to be compared separately.

Consider this example:

       user key | timestamp (desc)
k1 :         k1 | 999
k2:         k11 | 000

If user key and timestamp are NOT compared separately, k2 would be less than k1.

@MrCroxx MrCroxx added the bug Something isn't working label Mar 24, 2022
@MrCroxx MrCroxx self-assigned this Mar 24, 2022
@MrCroxx MrCroxx enabled auto-merge (squash) March 24, 2022 06:40
@MrCroxx MrCroxx mentioned this pull request Mar 24, 2022
Open
@MrCroxx MrCroxx merged commit 6ae9d9f into main Mar 24, 2022
@MrCroxx MrCroxx deleted the fix/full-key-compare branch March 24, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrCroxx MrCroxx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MrCroxx