Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is no longer possible to override the helper methods of the EnvParser class #40

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

MrDave1999
Copy link
Owner

The idea of these new changes is that the client does not need to know the implementation details of how the parser works, we call this the encapsulation principle and as the saying goes: "The fewer implementation details the client knows, the fewer changes it will make".

List of changes:

  • All fields of the EnvParser class have been changed to private.
  • All helper methods of the EnvParser class have been changed to private.
  • EnvParserOptions class was changed to internal.

@MrDave1999 MrDave1999 merged commit 4a9c43f into master Feb 17, 2022
@MrDave1999 MrDave1999 deleted the dev branch February 17, 2022 20:58
@MrDave1999 MrDave1999 added the breaking change A change in one part of a library that potentially causes other components to fail label Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change in one part of a library that potentially causes other components to fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant