Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add read config from yaml files #3

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

cesto93
Copy link

@cesto93 cesto93 commented Nov 9, 2023

Added support to configuration based on YAML file.
You can see an example yaml and a test.
I think this could be useful.

Copy link
Owner

@MrIceman MrIceman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrIceman
Copy link
Owner

@cesto93 cool, thanks for the contribution!

Copy link
Owner

@MrIceman MrIceman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some lint issues, if you solve them then we can merge this PR @cesto93

@cesto93
Copy link
Author

cesto93 commented Nov 28, 2023

I should have fix the lint issues with the new commit, let me know if the are others problems :)

@MrIceman MrIceman merged commit 5106fd5 into MrIceman:master Nov 28, 2023
@MrIceman
Copy link
Owner

@cesto93 awesome, merged your PR. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants