Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Allow users to edit their own record #1

Merged
merged 5 commits into from
Aug 29, 2013
Merged

Allow users to edit their own record #1

merged 5 commits into from
Aug 29, 2013

Conversation

dansullivan86
Copy link
Contributor

A user can edit their own profile without update-user-info permissions

@MrJuliuss
Copy link
Owner

Hi,

good idea !

Can you make somes change before merge pull request (or i can implement your request in my repo)?

like this :

<title>{{ (!empty($siteName)) ? $siteName : "Syntara"}} - {{$title}}</title> instead of <title>@if (!empty($siteName)){{ $siteName }}@else Syntara @endif - {{$title}}</title>

(same for nav-page)

To keep an uniform code, can you use this syntax :

if()
{
}
else
{
}

instead of

if(){
}else{
}

@dansullivan86
Copy link
Contributor Author

Added those fixes, sorry this fix adds in another commit that adds variables to add links to the nav bar, let me know if you need me to split them

@MrJuliuss
Copy link
Owner

Thx ;)

I test your custom nav, but it appears a problem : we can't nest several "custom nav" views. (example : add 2 packages based on Syntara, and add 2 customs nav)

@MrJuliuss
Copy link
Owner

Ok found a solution :

if a need to load several navigations, just need to :

View::composer('syntara::layouts.dashboard.master', function($view)
{
    $view->nest('navPages', 'allNavs');
});

nest a view extending others views :

@extends('first_package::nav')
@extends('second_package::nav')

Last thinks :

Add : '' to ternary nav conditions, likes this (there is an error in my page) !

{{ (!empty($navPagesRight)) ? $navPagesRight : ''}}

Last thinks : move $navPagesRight after the ajax loader ;)

Hmmm, and i think everything will be Ok :)

@dansullivan86
Copy link
Contributor Author

Sorry about that, hopefully this last commit fixes the issues.

MrJuliuss added a commit that referenced this pull request Aug 29, 2013
Allow users to edit their own record
@MrJuliuss MrJuliuss merged commit cbd8917 into MrJuliuss:master Aug 29, 2013
MrJuliuss pushed a commit that referenced this pull request Sep 4, 2014
add error filter

modify error page

modify filters

modify language messages and merge pull request #1 from Remo

support other languages

fix missing comma

add punctuation
MrJuliuss pushed a commit that referenced this pull request Sep 4, 2014
add error filter

modify error page

modify filters

modify language messages and merge pull request #1 from Remo

support other languages

fix missing comma

add punctuation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants