Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Resizing maximized window from the left border triggers Loop #149

Closed
2 tasks done
Zabriskije opened this issue Jan 2, 2024 · 5 comments · Fixed by #152
Closed
2 tasks done

🐛 Resizing maximized window from the left border triggers Loop #149

Zabriskije opened this issue Jan 2, 2024 · 5 comments · Fixed by #152
Assignees
Labels

Comments

@Zabriskije
Copy link
Contributor

Bug Description

When a maximized window is resized from the left border, Loop gets triggered.

Steps To Reproduce

  1. Maximize a window
  2. Drag from the left border

Expected Behavior

Loop shouldn't get triggered.

Actual Behavior

Loop gets triggered.

Screenshots

Left border bug

MacOS Version

Sonoma 14.2.1 (23C71)

Loop Version

Version 1.0.0-beta.13 (599)

Additional Context

I'm using the latest build found in #77.

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@Zabriskije Zabriskije added the Bug label Jan 2, 2024
@MrKai77 MrKai77 self-assigned this Jan 2, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Jan 2, 2024

Thanks for the bug report!
I just realized that window snapping triggers when a window's top left corner has been moved, but I guess a better way to do that would be to detect if the top left and bottom right corner of a window have been moved.

@MrKai77
Copy link
Owner

MrKai77 commented Jan 3, 2024

Let me know how this build is! I also managed to improve its behaviour on multi-display setups :)
Loop.zip

@Zabriskije
Copy link
Contributor Author

Now Loop doesn't get triggered, but it seems like the border is "sticky" until a certain point. It also makes Maximize and Top Half not working after the first try.

Latest build test

@MrKai77
Copy link
Owner

MrKai77 commented Jan 5, 2024

Alright, I fixed the Maximize/Top Left not triggering on the first try!
Loop.zip

As for the "stickiness", I'm fairly sure that it's a feature built-in to MacOS to assist with moving windows, since I'm able to reproduce it when Loop isn't running.

@Zabriskije
Copy link
Contributor Author

As for the "stickiness", I'm fairly sure that it's a feature built-in to MacOS to assist with moving windows, since I'm able to reproduce it when Loop isn't running.

Yup, you're right. I didn't notice that until today.

Seems fixed 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants