Qt4 compatibility #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKepzie
added a commit
that referenced
this pull request
Dec 15, 2013
#1 : Knobs are all passed around with a boost::shared_ptr now. It’s safer and should remain so. #2 : Settings are now using the Knobs interface and QSettings for serialization/deserialization. #3 : First implementation of the PreferencesPanel, reflecting the state of the settings of the application. #4 : Implementation of the colour picker gui: click the label of a colour knob, and then cmd click on a viewer to pick a colour.
This was referenced Jun 22, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly include fixes, and only two Qt4-specific changes (look for QT_VERSION in the changes);
The .pro is now easier to maintain and more portable, thanks to pkg-config.
Powiter compiles and launches with Qt4. I didn't notice any lost functionality.
Qt 4 compatibility is better, as long as no Qt5-specific feature is needed, since the Qt4 code base is much more mature.