Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earnings Tracking Error #2

Closed
liquidone opened this issue Feb 23, 2018 · 8 comments
Closed

Earnings Tracking Error #2

liquidone opened this issue Feb 23, 2018 · 8 comments
Labels
bug Something isn't working

Comments

@liquidone
Copy link

Hi,

Please look at the screenshot. I am getting a similar error on 2 different rigs. Not sure how to resolve it or what it stems from.

Great project by the way!
earnings error

@MrPlusGH
Copy link
Owner

Error not handled properly when API call fails.
Check if occurrence of Threshold being null which should never be for supported pools. (double check)

Will fix in next version.

@MrPlusGH MrPlusGH added the bug Something isn't working label Feb 23, 2018
@nemosminer
Copy link
Contributor

nemosminer commented Feb 23, 2018

@liquidone
Copy link
Author

Fantastic, thank you!

It's been driving me nuts for the last few days :)

@MrPlusGH
Copy link
Owner

Thanks Nemo. I really like our collaboration!

This is more of a workaround than a fix. That's a great solution until I find the root cause.
The payment threshold is not coming from the pool but from our service that I maintain. So this should never be 0 and even if so. The code should resist to this.
Note that some people reporting this issues were referring MPH and hashrefinery which are not yet supported for earning tracker. (see readme)
However, some reported for zpool which is supported so I'll investigate on this one.

Keeping opened as bug for now.

@liquidone
Copy link
Author

I'm using the current master an on all rigs, across 3 different pools zpool,ahash and zerg and I am seeing "Automatic Payouts Disabled" on all of them.

the error is gone but earnings tracking still doesn't appear to be working.

@MrPlusGH
Copy link
Owner

Implemented fix on master.
Would be great if you could test and report.

Will properly ignore unsupported pools.
Will properly ignore when webservice failure.

@liquidone
Copy link
Author

ok I will go ahead and test and report now :) Thanks for all your help!

@liquidone
Copy link
Author

Just to be clear, earnings data will not show until Trust = 100% ? Is that correct?

@MrPlusGH MrPlusGH closed this as completed Mar 7, 2018
MrPlusGH added a commit that referenced this issue Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants