Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D&D v4.0.x/2024 Known Issues #505

Open
1 of 36 tasks
MrPrimate opened this issue Sep 16, 2024 · 17 comments
Open
1 of 36 tasks

D&D v4.0.x/2024 Known Issues #505

MrPrimate opened this issue Sep 16, 2024 · 17 comments
Assignees
Labels
bug Something isn't working

Comments

@MrPrimate
Copy link
Owner

MrPrimate commented Sep 16, 2024

This is a list of Known Issues for DDB Importer in the 4.0.x System (DDB Importer v6.0.0 and higher):

  • 2024 Features and spells are not parsed correctly
  • Feat Muncher is not enabled
  • Species Muncher is not enabled
  • Class Muncher is not enabled
  • Background Muncher is not enabled
  • Not all Spells have the same out of the box effects as in v5 (Please see list below)
  • Not all Items have the same out of the box effects as in v5 (Please see list below)
  • Not all Features have the same out of the box effects as in v5 (Please see list below)
  • 2024 Rangers do not get their full spells list (they are now prepared casters)
  • 2014 spells/items get imported into the same compendium folders as the 2024, provide a way to import into a Legacy folder
  • There is an icon missing for.... (please add suggestions below)
  • Some effects won't generate duration correctly
  • New Summon Spells are not configured correctly
  • Updates to back to DDB are very hit and miss.
  • Resource retention for items does not always work, depending on activity.
  • Spell Sniper range increase is not applied to imported characters for either 2014 or 2024
  • Some Monster Features need parsing corrections, please note any below that are not already noted.
  • There is no option (yet) to determine which version of the spell gets applied to monsters.
  • Spells in the DDB Spells compendium are not added to the Spell Lists.

Please feel free to comment with any specifics or instances where the 2014/2024 rules differ.

Spell Issues and Missing Effects

2014 Missing Effects

  • Ensnaring Strike needs effect and damage activity
  • Geas
  • Phantasmal Killer

Item Issues and Missing Effects

Feature Issues and Missing Effects

  • Wild Companion Spell uses spell slots and not wildshape uses (this is how its set up on DDB)
  • Dancing Bards Agile Strikes not adjusted for agile property.
  • Psionic Sorcery does not create spells or have a feature to consume spells

Monster Feature Corrections Required

  • Clay Golem Haste is parsed as a bonus action.
  • Dullahan Battleaxe damage is not parsed correctly
  • Dullahan parses some legendary actions as mythic actions incorrectly
  • Duergar Warlord Psychic-Attuned Hammer damage is not correctly parsed
  • Autumn Eladrin Cure Wounds is not cast as the correct level spell
  • Flumph Tendrils do not parse damage correctly
  • Living Blade of Disaster parses quite badly
  • Nilbog, Reversal of Fortune parsing is not quite right
  • Nosferatu Bite does not parse correctly
  • A Dragon's Frightful presence does not generate a range and area shape
  • Monsters with Magic Weapons feature do not always get the magic property applied to their weapons.
@MrPrimate MrPrimate added the bug Something isn't working label Sep 16, 2024
@MrPrimate MrPrimate self-assigned this Sep 16, 2024
@MrPrimate MrPrimate pinned this issue Sep 16, 2024
@crlgn
Copy link

crlgn commented Sep 20, 2024

Thank you so much for all the work!
On my test munching I found an issue with these two items - Needler Pistol and Paralysis Pistol - which error out with message "Failed to find loot type for ". Both are from Quests from the Infinite Staircase.

// Needler Pistol - data._id: "3W5DAaabtgQKuCoO"
{
    "id": 387,
    "baseTypeId": 2103445194,
    "definitionKey": "2103445194:387"
}

// Paralysis Pistol  - data._id: "0dTXYB8HBeRbwSo8"
{
    "id": 388,
    "baseTypeId": 2103445194,
    "definitionKey": "2103445194:388"
}

I noticed that on DnD Beyond the Needler Pistol has two links, one of them is returning a 404 error

Paralysis Pistol has only one "equipment" link

Let me know if it helps you to gather any other parts of the json, I can definitely do that if needed.

@MrPrimate
Copy link
Owner Author

Thank you so much for all the work! On my test munching I found an issue with these two items - Needler Pistol and Paralysis Pistol - which error out with message "Failed to find loot type for ". Both are from Quests from the Infinite Staircase.

// Needler Pistol - data._id: "3W5DAaabtgQKuCoO"
{
    "id": 387,
    "baseTypeId": 2103445194,
    "definitionKey": "2103445194:387"
}

// Paralysis Pistol  - data._id: "0dTXYB8HBeRbwSo8"
{
    "id": 388,
    "baseTypeId": 2103445194,
    "definitionKey": "2103445194:388"
}

I noticed that on DnD Beyond the Needler Pistol has two links, one of them is returning a 404 error

* https://www.dndbeyond.com/equipment/366-needler-pistol

* https://www.dndbeyond.com/equipment/66-needler-pistol

Paralysis Pistol has only one "equipment" link

* https://www.dndbeyond.com/equipment/367-paralysis-pistol

Let me know if it helps you to gather any other parts of the json, I can definitely do that if needed.

It should've imported these for you despite those error messages. Is that not the case?

@kraytGG
Copy link

kraytGG commented Sep 20, 2024

I am receiving this issue when attempting to import a player.
Capture

@lholden
Copy link

lholden commented Sep 20, 2024

image
A minor issue. But the "D&D Beyond" icon on item sheets overlaps the close and configure buttons.

@MrPrimate
Copy link
Owner Author

I am receiving this issue when attempting to import a player. Capture

This is fixed in 6.0.2 out in an hour or so.

@MrPrimate
Copy link
Owner Author

image A minor issue. But the "D&D Beyond" icon on item sheets overlaps the close and configure buttons.

Alas, this is beyond my CSS Skills. If anyone is reading this and knows how to fix it, PRs are welcome.

@lholden
Copy link

lholden commented Sep 20, 2024

Alas, this is beyond my CSS Skills. If anyone is reading this and knows how to fix it, PRs are welcome.

Could just use an image with a square aspect ratio?

https://www.dndbeyond.com/content/1-0-2933-0/skins/waterdeep/images/dnd-beyond-b-red.png

@crlgn
Copy link

crlgn commented Sep 20, 2024

Thank you so much for all the work! On my test munching I found an issue with these two items - Needler Pistol and Paralysis Pistol - which error out with message "Failed to find loot type for ". Both are from Quests from the Infinite Staircase.

// Needler Pistol - data._id: "3W5DAaabtgQKuCoO"
{
    "id": 387,
    "baseTypeId": 2103445194,
    "definitionKey": "2103445194:387"
}

// Paralysis Pistol  - data._id: "0dTXYB8HBeRbwSo8"
{
    "id": 388,
    "baseTypeId": 2103445194,
    "definitionKey": "2103445194:388"
}

I noticed that on DnD Beyond the Needler Pistol has two links, one of them is returning a 404 error

* https://www.dndbeyond.com/equipment/366-needler-pistol

* https://www.dndbeyond.com/equipment/66-needler-pistol

Paralysis Pistol has only one "equipment" link

* https://www.dndbeyond.com/equipment/367-paralysis-pistol

Let me know if it helps you to gather any other parts of the json, I can definitely do that if needed.

It should've imported these for you despite those error messages. Is that not the case?

Yes, but it was added as a consumable trinket.

@crlgn
Copy link

crlgn commented Sep 20, 2024

image A minor issue. But the "D&D Beyond" icon on item sheets overlaps the close and configure buttons.

Alas, this is beyond my CSS Skills. If anyone is reading this and knows how to fix it, PRs are welcome.

This works for me:

a.header-button.control.ddb-open-url {
    width: auto;
    aspect-ratio: auto;
}

@MrPrimate
Copy link
Owner Author

image A minor issue. But the "D&D Beyond" icon on item sheets overlaps the close and configure buttons.

Alas, this is beyond my CSS Skills. If anyone is reading this and knows how to fix it, PRs are welcome.

This works for me:

a.header-button.control.ddb-open-url {
    width: auto;
    aspect-ratio: auto;
}

Thank you!!!!

@crlgn
Copy link

crlgn commented Oct 10, 2024

I notice all spells have duplicated activities, and all emanation area spells are missing the template type. Are these known issues? Examples: Word of Radiance, Aura of Vitality.
Let me know if there's anything you can outsource for these situations, I've been manually adding templates for a bunch of those spells and I can code so maybe I can help.

@MrPrimate
Copy link
Owner Author

I notice all spells have duplicated activities, and all emanation area spells are missing the template type. Are these known issues? Examples: Word of Radiance, Aura of Vitality. Let me know if there's anything you can outsource for these situations, I've been manually adding templates for a bunch of those spells and I can code so maybe I can help.

The template is a known issue due to a data change at DDB and will be fixed in the next release.

The duplicate issue however I can not reproduce. did you much with the latest version and ensure you had update existing things checked?

@crlgn
Copy link

crlgn commented Oct 11, 2024

I notice all spells have duplicated activities, and all emanation area spells are missing the template type. Are these known issues? Examples: Word of Radiance, Aura of Vitality. Let me know if there's anything you can outsource for these situations, I've been manually adding templates for a bunch of those spells and I can code so maybe I can help.

The template is a known issue due to a data change at DDB and will be fixed in the next release.

The duplicate issue however I can not reproduce. did you much with the latest version and ensure you had update existing things checked?

Yes, I munched with that option on. My first munch was right on the first release of v6.0.0, though I updated recently. Maybe I should remove all spells and munch again?

EDIT: I deleted all spells and reimported - the duplicates are gone. Not sure what caused it.
image
image
image

@oestred
Copy link

oestred commented Oct 12, 2024

Bug - when importing a 2024 character, some inventory items look normal, but there are always several that take up many lines and look like this.
image

@MrPrimate
Copy link
Owner Author

Bug - when importing a 2024 character, some inventory items look normal, but there are always several that take up many lines and look like this. image

Can you:

  • provide a public character url
  • which character sheet are you using (default, legacy, or other)?
  • does it do this with all other modules disabled?

@oestred
Copy link

oestred commented Oct 14, 2024

Bug - when importing a 2024 character, some inventory items look normal, but there are always several that take up many lines and look like this. image

Can you:

  • provide a public character url
  • which character sheet are you using (default, legacy, or other)?
  • does it do this with all other modules disabled?

Ah, good questions. I tried it without any modules and it worked on the default sheet. I am using Tidy 5E sheet usually. It looks like Tidy 5E is doing that only with items in a container (backpack in this case) so it looks like a Tidy 5E bug. I will report it there.

Thank you

@kgar
Copy link

kgar commented Oct 19, 2024

In Tidy 5e Sheets, it looks like the window header / title bar option no longer works in dnd5e 4.0.x. I remember it working for Tidy sheets some time ago, but I haven't checked in a while. Here's what I'm getting now:

image

image

If there's something I can do to assist, let me know.

Tidy PCs and NPCs are still using App V1 + Svelte from before.
Depending on dnd5e 4.1.x+ and Foundry V13+, Tidy may have to move all sheets to App V2, which could affect the class name, but the API functions for checking if a sheet is a Tidy character / NPC should always work, generally.

There is a sheet overhaul underway that will also use App V2 and provide new layouts for PCs, NPCs, vehicles, groups, and items, but it will be some time before it is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants