Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify ENV Path for pkger for failing CI #6

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

firelegacy0
Copy link
Collaborator

No description provided.

@firelegacy0 firelegacy0 changed the title Remove pkger from Dockerfile Specify ENV Path for pkger for failing CI Nov 8, 2023
@firelegacy0
Copy link
Collaborator Author

firelegacy0 commented Nov 8, 2023

@MrSaints Will try to use pkger again since the current main.go uses it for embedding static files, might just be a path issue in the failing CI

Dockerfile Outdated
Comment on lines 48 to 51
RUN wget https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.17.3/kubeseal-0.17.3-linux-${TARGETARCH}.tar.gz -O kubeseal.tar.gz \
&& tar -xzf kubeseal.tar.gz -C /tmp/ \
&& install -m 755 /tmp/kubeseal /usr/local/bin/kubeseal \
&& rm -rf kubeseal.tar.gz /tmp/kubeseal
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops accidentally removed by mistake, oversight from my end

@MrSaints
Copy link
Owner

MrSaints commented Nov 8, 2023

@firelegacy0 FWIW, Go has native file embedding. How much lift is it to switch to that?

@firelegacy0
Copy link
Collaborator Author

firelegacy0 commented Nov 9, 2023

@firelegacy0 FWIW, Go has native file embedding. How much lift is it to switch to that?

Should just require some code change in the libraries/imports used in main.go to use the native package, though may require testing to see if it works similar as our current running KubeSeal.

FWIW i think we could:

  1. Stick to pkger by using this current setup, see if it builds correctly (then it follows the same behavior/setup we have now in KubeSeal)
  2. If it doesnt work, will switch to Go's native embed, update main.go + Dockerfile

@MrSaints MrSaints merged commit 80ffc1c into master Nov 9, 2023
@MrSaints MrSaints deleted the update-multiarch-support branch November 9, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants