Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21-set-up-linting #23

Merged
merged 5 commits into from
May 16, 2024
Merged

21-set-up-linting #23

merged 5 commits into from
May 16, 2024

Conversation

BetOnJeanette
Copy link
Collaborator

What was the Problem?

We did not have linting set up on the project.

Why was this a Problem?

This could result in inconsistent styles, making the code harder to maintain.

What does this do to Address the Problem?

This update adds two dev-packages: eslint and its stylistic plugin. We also configured the styles to match the current style.

@BetOnJeanette BetOnJeanette self-assigned this May 16, 2024
@BetOnJeanette BetOnJeanette linked an issue May 16, 2024 that may be closed by this pull request
@BetOnJeanette BetOnJeanette added enhancement New feature or request Priority: Medium This is bad, but not unusable labels May 16, 2024
Copy link
Owner

@MsZoezo MsZoezo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨🫶🏻

@BetOnJeanette BetOnJeanette merged commit 7912988 into main May 16, 2024
@BetOnJeanette BetOnJeanette deleted the 21-set-up-linting branch May 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: Medium This is bad, but not unusable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up linting
2 participants