Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding time-based cosmic track fit #198

Merged
merged 22 commits into from
May 26, 2020
Merged

Conversation

bonventre
Copy link
Contributor

New modules:

  • SimpleTimeCluster_module.cc
  • LineFinder_module.cc

Updated cosmic track algorithm:

  • Cleanup of persistent dataproducts CosmicTrack and CosmicTrackSeed
  • Removal of CosmicTrackFinderData
  • Added LineFinder seeding
  • Added GaussianDriftFit

Modified StrawResponse to help minuit convergence:

  • Reworked StrawDrift to use fixed size binning in both D2T and T2D, and added 2-D interpolation
  • Added driftTimeError and driftTimeOffset based on parameterized residual model

@FNALbuild
Copy link
Collaborator

Hi @bonventre,
You have proposed changes to files in these packages:

  • TrackerConfig
  • RecoDataProducts
  • TrackerConditions
  • CosmicReco

which require these tests: build.

FNALbuild is explained here.

Copy link
Contributor

@sophiemiddleton sophiemiddleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me :)

@brownd1978 brownd1978 self-assigned this May 20, 2020
Copy link
Collaborator

@brownd1978 brownd1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like important upgrades and the code is good, just a few small things to fix/review.

CosmicReco/src/SimpleTimeCluster_module.cc Show resolved Hide resolved
@@ -237,6 +237,12 @@ StrawResponse : {
0.156641, 0.151196, 0.146546, 0.144069, 0.139858, 0.135838, 0.13319,
0.132159, 0.130062, 0.123545, 0.120212 ]

useParameterizedDriftErrors : false
parameterizedDriftBins : 25000
parameterizedDriftSigma : 1.39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these stable configuration parameters, or do we expect them to change due to (say) changing resolution or thresholds or...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are definitely calibrations that will change and be updated similarly to the rest of the StrawResponse parameters. I extract these parameters using the TrackerMCTune package.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these parameters come from a proditions table eventually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we will have to plan out how tables will look and how they will get updated as we analyze the VST data.

CosmicReco/src/CosmicSeedFilter_module.cc Show resolved Hide resolved
@@ -31,16 +29,9 @@ namespace mu2e {
TrkFitFlag _status; // status of processes used to create this seed
// helixOK: ???, helixConverged: ???, circleInit: ???, Straight: ???, hitsOK: ???
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can safely ignore those bits (not set them). We could discuss if it's worthwhile to generalize the 'init' bits in this flag. hitsOK should have the same meaning here (enough hits to perform the fit).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are still used by @sophiemiddleton so I'll leaving any changes here up to her

CosmicReco/inc/PDFFit.hh Show resolved Hide resolved
@brownd1978
Copy link
Collaborator

@FNALbuild run build test

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for ref b932e55: build

@FNALbuild
Copy link
Collaborator

☀️ The tests passed at ref b932e55.

Test Result Details
scons build (prof) ✔️ Log file. Build time: 11 min 42 sec
ceSimReco ✔️ Log file
g4test_03MT ✔️ Log file
transportOnly ✔️ Log file
PS ✔️ Log file
g4study ✔️ Log file
cosmicSimReco ✔️ Log file
FIXME, TODO count 〰️ TODO (2) FIXME (11) in 27 files
clang-tidy 〰️ 0 errors 63 warnings

For more information, please check the job page here.

@brownd1978
Copy link
Collaborator

@FNALbuild run build test

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for ref 9e96991: build

@FNALbuild
Copy link
Collaborator

☀️ The tests passed at ref 9e96991.

Test Result Details
scons build (prof) ✔️ Log file. Build time: 11 min 47 sec
ceSimReco ✔️ Log file
g4test_03MT ✔️ Log file
transportOnly ✔️ Log file
PS ✔️ Log file
g4study ✔️ Log file
cosmicSimReco ✔️ Log file
FIXME, TODO count 〰️ TODO (2) FIXME (11) in 27 files
clang-tidy 〰️ 0 errors 63 warnings

For more information, please check the job page here.

@brownd1978 brownd1978 merged commit 17dc9d6 into Mu2e:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants