-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mu2eII_SM21: Merge head of Offline including new physics generators #686
Conversation
adjustments for pileup tests
add StrawADCWaveform
Stopped Muon Generators
… plots to be sensitive to offspill timing. Remove spurious dependency.
fix messenger cout error message
Memory leak fix in CosmicCRY.cc
Fixes for OffSpill digitization
DbService update for DQM
…on of TFileDirectory class
Art v310 new
remove two missed references to hepPDT
Hi @sophiemiddleton,
which require these tests: build. @Mu2e/write, @Mu2e/mu2eii_sm21_ci have access to CI actions on Mu2eII_SM21. The following users requested to be notified about changes to these packages: ⌛ The following tests have been triggered for 6fa29a5: build (Build queue has 9 jobs) |
☔ The tests failed for 6fa29a5.
N.B. These results were obtained from a build of this Pull Request at 6fa29a5 after being merged into the base branch at 38b8236. For more information, please check the job page here. |
@FNALbuild run build test with Mu2e/Production#152 |
⌛ The following tests have been triggered for 6fa29a5: build (Build queue has 7 jobs) |
☀️ The tests passed at 6fa29a5.
N.B. These results were obtained from a build of this Pull Request at 6fa29a5 after being merged into the base branch at 38b8236. For more information, please check the job page here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After an off-github discussion with Sophie, we decided that threshold for merging is that it passes the CI. Any additional testing is the responsibility of the Mu2e-II co-convenors.
Last big PR for Mu2eII_SM21 to include the new physics generators