Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mu2eII_SM21: Merge head of Offline including new physics generators #686

Merged
merged 337 commits into from
Jan 14, 2022

Conversation

sophiemiddleton
Copy link
Contributor

Last big PR for Mu2eII_SM21 to include the new physics generators

rlcee and others added 30 commits October 16, 2021 11:43
… plots to be sensitive to offspill timing. Remove spurious dependency.
fix messenger cout error message
Memory leak fix in CosmicCRY.cc
Fixes for OffSpill digitization
@FNALbuild
Copy link
Collaborator

Hi @sophiemiddleton,
You have proposed changes to files in these packages:

  • TrkDiag
  • Mu2eHallGeom
  • ExtinctionMonitorFNAL
  • GlobalConstantsService
  • Filters
  • EventDisplay
  • Mu2eInterfaces
  • TrkHitReco
  • GeometryService
  • Trigger
  • DbService
  • DAQ
  • ProductionSolenoidGeom
  • Validation
  • CRVResponse
  • ProductionTargetGeom
  • Mu2eBTrk
  • CosmicReco
  • DbTables
  • Compression
  • MCDataProducts
  • CalPatRec
  • Mu2e
  • EventMixing
  • fcl
  • CommonMC
  • Sources
  • GeomPrimitives
  • CaloDiag
  • ConditionsService
  • ProtonBeamDumpGeom
  • TrkReco
  • TrackerMC
  • /
  • RecoDataProducts
  • SimulationConditions
  • TrkFilters
  • TrackerConditions
  • CaloFilters
  • Mu2eUtilities
  • CaloMC
  • DataProducts
  • Mu2eKinKal
  • EventGenerator
  • Print
  • CRVAnalysis
  • Analyses
  • Mu2eG4
  • TrkPatRec
  • TEveEventDisplay

which require these tests: build.

@Mu2e/write, @Mu2e/mu2eii_sm21_ci have access to CI actions on Mu2eII_SM21.

The following users requested to be notified about changes to these packages:
@resnegfk

⌛ The following tests have been triggered for 6fa29a5: build (Build queue has 9 jobs)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☔ The tests failed for 6fa29a5.

Test Result Details
merge Merged 6fa29a5 at 38b8236
build (prof) Log file. Build time: 12 min 47 sec
ceSimReco Log file. Return Code 9.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file. Return Code 9.
ceDigi Log file. Return Code 24.
muDauSteps Log file. Return Code 9.
ceMix Log file. Return Code 24.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 〰️ TODO (0) FIXME (11) in 42 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 6fa29a5 after being merged into the base branch at 38b8236.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@sophiemiddleton
Copy link
Contributor Author

@FNALbuild run build test with Mu2e/Production#152

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for 6fa29a5: build (Build queue has 7 jobs)

@FNALbuild
Copy link
Collaborator

☀️ The tests passed at 6fa29a5.

Test Result Details
test with Included Mu2e/Production#152 @ a60cf42e70dff4915277639e147c31fc82965320 by merge
merge Merged 6fa29a5 at 38b8236
build (prof) Log file. Build time: 14 min 42 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 〰️ TODO (0) FIXME (11) in 42 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 6fa29a5 after being merged into the base branch at 38b8236.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Collaborator

@kutschke kutschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After an off-github discussion with Sophie, we decided that threshold for merging is that it passes the CI. Any additional testing is the responsibility of the Mu2e-II co-convenors.

@kutschke kutschke merged commit 810d41e into Mu2e:Mu2eII_SM21 Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.