Updated TEve Event Display to plot the new KKTraj options #900

sophiemiddleton · 2022-11-25T20:26:49Z

This code allows plotting of the KinKal trajectories as requested by @brownd1978

Note - the REve code is the newest version of the Eve Event Display so any comments on general coding should be provided on that version not this. TEve is maintained as REve currently does not support all the features we developed there.

FNALbuild · 2022-11-25T20:27:24Z

Hi @sophiemiddleton,
You have proposed changes to files in these packages:

TEveEventDisplay

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for b202857: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild · 2022-11-25T20:50:13Z

☀️ The build tests passed at b202857.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged `b202857` at `d88a7ac`
build (prof)	✅	Log file. Build time: 13 min 10 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	🔶	TODO (2) FIXME (0) in 4 files
clang-tidy	〰️	0 errors 0 warnings
whitespace check	🔶	found whitespace errors

N.B. These results were obtained from a build of this Pull Request at b202857 after being merged into the base branch at d88a7ac.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

brownd1978

Some questions and suggestions.

brownd1978 · 2022-11-30T00:18:57Z

TEveEventDisplay/src/TEveMu2eDataInterface.cc

+using LHPT = KinKal::PiecewiseTrajectory<KinKal::LoopHelix>;
+using CHPT = KinKal::PiecewiseTrajectory<KinKal::CentralHelix>;
+using KLPT = KinKal::PiecewiseTrajectory<KinKal::KinematicLine>;
+template<class KTRAJ> void TEveMu2eDataInterface::AddKinKalTrajectory( std::unique_ptr<KTRAJ> &trajectory, TEveMu2eCustomHelix *line, TEveMu2eCustomHelix *line_twoDXY, TEveMu2eCustomHelix *line_twoDXZ){


I suggest const& trajectory

brownd1978 · 2022-11-30T00:20:28Z

TEveEventDisplay/src/TEveMu2eDataInterface.cc

+  line->SetPoint(0,pointmmTocm(InMu2e.x()), pointmmTocm(InMu2e.y()) , pointmmTocm(InMu2e.z()));
+  line_twoDXY->SetPoint(0,pointmmTocm(x1), pointmmTocm(y1) , pointmmTocm(z1));
+  line_twoDXZ->SetPoint(0,pointmmTocm(x1), pointmmTocm(y1) , pointmmTocm(z1));
+  for(double t=t1; t<=t2; t+=0.1)


Can the time step be configurable? 100ps is ~30mm, which is quite coarse

I could change by a factor of 10 i.e. 0.01 (or any toher number you want)
I dont think havig it as a FCL parameter is a good idea. We already have such a large amount of parameters

brownd1978 · 2022-11-30T00:21:55Z

TEveEventDisplay/src/TEveMu2eDataInterface.cc

+          AddKinKalTrajectory<KLPT>(trajectory,line,line_twoDXY,line_twoDXZ);
+        }
+
+


The indenting formatting looks off

brownd1978 · 2022-11-30T00:22:56Z

TEveEventDisplay/src/TEveMu2eDataInterface.cc

+    const KalSeedCollection* seedcol = track_list[j];
+    colour.push_back(j+3);
+    if(seedcol!=0){  
+     for(unsigned int k = 0; k < seedcol->size(); k = k + 20){ 


Why does k advance by 20? it pretty much guarantees you'll only see the 1st track.

FNALbuild · 2022-11-30T15:41:46Z

📝 The HEAD of main has changed to 1b51ea5. Tests are now out of date.

kutschke · 2022-11-30T15:42:44Z

@FNALbuild run build test

FNALbuild · 2022-11-30T15:43:15Z

⌛ The following tests have been triggered for b202857: build (Build queue has 1 jobs)

FNALbuild · 2022-11-30T16:16:46Z

☀️ The build tests passed at b202857.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged `b202857` at `1b51ea5`
build (prof)	✅	Log file. Build time: 22 min 03 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	🔶	TODO (2) FIXME (0) in 4 files
clang-tidy	〰️	0 errors 0 warnings
whitespace check	🔶	found whitespace errors

N.B. These results were obtained from a build of this Pull Request at b202857 after being merged into the base branch at 1b51ea5.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke · 2022-12-14T23:30:37Z

@sophiemiddleton A gentle reminder that this PR is waiting for you to answer a questions/comments from Dave.

FNALbuild · 2022-12-14T23:31:25Z

📝 The HEAD of main has changed to 42696d6. Tests are now out of date.

kutschke · 2022-12-14T23:51:41Z

@FNALbuild run build test

FNALbuild · 2022-12-14T23:52:10Z

⌛ The following tests have been triggered for b202857: build (Build queue is empty)

FNALbuild · 2022-12-15T00:15:02Z

☀️ The build tests passed at b202857.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged `b202857` at `42696d6`
build (prof)	✅	Log file. Build time: 12 min 52 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	🔶	TODO (2) FIXME (0) in 4 files
clang-tidy	〰️	0 errors 0 warnings
whitespace check	🔶	found whitespace errors

N.B. These results were obtained from a build of this Pull Request at b202857 after being merged into the base branch at 42696d6.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke · 2022-12-15T05:29:35Z

I also just noticed that there are whitespace errors - so please address those too. If you follow the link beside the whitespace link you will see where the problems are. You need to be on fgz or on VPN to see it. Or you can use curl to download the file when you are logged into a mu2egpvm node.

sophiemiddleton · 2022-12-15T18:53:28Z

I think I addressed the various issues, let me know if not

brownd1978 · 2022-12-15T22:25:30Z

@FNALbuild run build test

FNALbuild · 2022-12-15T22:25:58Z

⌛ The following tests have been triggered for d73a510: build (Build queue is empty)

FNALbuild · 2022-12-15T22:47:26Z

☀️ The build tests passed at d73a510.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged `d73a510` at `430bd32`
build (prof)	✅	Log file. Build time: 11 min 58 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 4 files
clang-tidy	〰️	0 errors 0 warnings
whitespace check	🔶	found whitespace errors

N.B. These results were obtained from a build of this Pull Request at d73a510 after being merged into the base branch at 430bd32.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

sophieMu2e added 3 commits November 25, 2022 14:05

almost owrking, need coord fix

f2a7113

corrds fixed, added opt

b1466ba

corrds fixed, added opt

b202857

FNALbuild added build pending build running and removed build pending labels Nov 25, 2022

FNALbuild added build finished and removed build running labels Nov 25, 2022

kutschke assigned kutschke and brownd1978 and unassigned kutschke Nov 25, 2022

brownd1978 reviewed Nov 30, 2022

View reviewed changes

FNALbuild added build pending and removed build finished labels Nov 30, 2022

FNALbuild added build running and removed build pending labels Nov 30, 2022

FNALbuild added build finished and removed build running labels Nov 30, 2022

FNALbuild added build pending and removed build finished labels Dec 14, 2022

FNALbuild added build running and removed build pending labels Dec 14, 2022

FNALbuild added build finished and removed build running labels Dec 15, 2022

sophieMu2e added 2 commits December 15, 2022 11:34

white space

101c7b3

changes for PR

d73a510

FNALbuild added build pending and removed build finished labels Dec 15, 2022

FNALbuild added build running and removed build pending labels Dec 15, 2022

brownd1978 approved these changes Dec 15, 2022

View reviewed changes

FNALbuild added build finished and removed build running labels Dec 15, 2022

brownd1978 merged commit 9b88132 into Mu2e:main Dec 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated TEve Event Display to plot the new KKTraj options #900

Updated TEve Event Display to plot the new KKTraj options #900

sophiemiddleton commented Nov 25, 2022 •

edited

Loading

FNALbuild commented Nov 25, 2022

FNALbuild commented Nov 25, 2022

brownd1978 left a comment

brownd1978 Nov 30, 2022

sophiemiddleton Dec 15, 2022

brownd1978 Nov 30, 2022

sophiemiddleton Dec 15, 2022

brownd1978 Nov 30, 2022

sophiemiddleton Dec 15, 2022

brownd1978 Nov 30, 2022

sophiemiddleton Dec 15, 2022

FNALbuild commented Nov 30, 2022

kutschke commented Nov 30, 2022

FNALbuild commented Nov 30, 2022

FNALbuild commented Nov 30, 2022

kutschke commented Dec 14, 2022

FNALbuild commented Dec 14, 2022

kutschke commented Dec 14, 2022

FNALbuild commented Dec 14, 2022

FNALbuild commented Dec 15, 2022

kutschke commented Dec 15, 2022

sophiemiddleton commented Dec 15, 2022

brownd1978 commented Dec 15, 2022

FNALbuild commented Dec 15, 2022

FNALbuild commented Dec 15, 2022

		AddKinKalTrajectory<KLPT>(trajectory,line,line_twoDXY,line_twoDXZ);
		}

Updated TEve Event Display to plot the new KKTraj options #900

Updated TEve Event Display to plot the new KKTraj options #900

Conversation

sophiemiddleton commented Nov 25, 2022 • edited Loading

FNALbuild commented Nov 25, 2022

FNALbuild commented Nov 25, 2022

brownd1978 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FNALbuild commented Nov 30, 2022

kutschke commented Nov 30, 2022

FNALbuild commented Nov 30, 2022

FNALbuild commented Nov 30, 2022

kutschke commented Dec 14, 2022

FNALbuild commented Dec 14, 2022

kutschke commented Dec 14, 2022

FNALbuild commented Dec 14, 2022

FNALbuild commented Dec 15, 2022

kutschke commented Dec 15, 2022

sophiemiddleton commented Dec 15, 2022

brownd1978 commented Dec 15, 2022

FNALbuild commented Dec 15, 2022

FNALbuild commented Dec 15, 2022

sophiemiddleton commented Nov 25, 2022 •

edited

Loading