Hot fix for Issue #3010 #3074
Hot fix for Issue #3010 #3074
Conversation
… into feature/portal
| 'mud-popover-bottom-center': 'mud-popover-top-center', | ||
| 'mud-popover-bottom-right': 'mud-popover-top-right', | ||
| }, | ||
| 'top-and-left': { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| 'top-and-left': { | |
| "top-and-left"': { |
| } | ||
| } else if (classList.contains('mud-popover-top-right')) { | ||
| if (deltaBottom < gracePeriod && deltaToLeft < gracePeriod) { | ||
| selector = 'top-and-right'; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| selector = 'top-and-right'; | |
| selector ="top-and-right"'; |
| 'mud-popover-bottom-right': 'mud-popover-top-right', | ||
| }, | ||
| 'top-and-left': { | ||
| 'mud-popover-top-left': 'mud-popover-bottom-right', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| 'mud-popover-top-left': 'mud-popover-bottom-right', | |
| "mud-popover-top-left"': 'mud-popover-bottom-right', |
| let selector = popoverContentNode.mudPopoverFliped; | ||
|
|
||
| if (!selector) { | ||
| if (classList.contains('mud-popover-top-left')) { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| if (classList.contains('mud-popover-top-left')) { | |
| if (classList.contains"mud-popover-top-left"')) { |
| else if (list.indexOf('mud-popover-center-left') >= 0) { | ||
| offsetX = 0; | ||
| offsetY = -selfRect.height / 2; | ||
| } else if (list.indexOf('mud-popover-center-center') >= 0) { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| } else if (list.indexOf('mud-popover-center-center') >= 0) { | |
| } else if (list.indexOf"mud-popover-center-center"') >= 0) { |
| } else if (list.indexOf('mud-popover-anchor-center-center') >= 0) { | ||
| left = boundingRect.left + boundingRect.width / 2; | ||
| top = boundingRect.top + boundingRect.height / 2; | ||
| } else if (list.indexOf('mud-popover-anchor-center-right') >= 0) { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| } else if (list.indexOf('mud-popover-anchor-center-right') >= 0) { | |
| } else if (list.indexOf"mud-popover-anchor-center-right"') >= 0) { |
| 'bottom': { | ||
| 'mud-popover-bottom-left': 'mud-popover-top-left', | ||
| 'mud-popover-bottom-center': 'mud-popover-top-center', | ||
| 'mud-popover-bottom-right': 'mud-popover-top-right', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| 'mud-popover-bottom-right': 'mud-popover-top-right', | |
| "mud-popover-bottom-right"': 'mud-popover-top-right', |
| } | ||
| } | ||
|
|
||
| else if (classList.contains('mud-popover-center-left')) { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| else if (classList.contains('mud-popover-center-left')) { | |
| else if (classList.contains"mud-popover-center-left"')) { |
| } else if (deltaToRight < gracePeriod) { | ||
| selector = 'left'; | ||
| } | ||
| } else if (classList.contains('mud-popover-bottom-center')) { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| } else if (classList.contains('mud-popover-bottom-center')) { | |
| } else if (classList.contains"mud-popover-bottom-center"')) { |
| 'mud-popover-top-right': 'mud-popover-bottom-left', | ||
| }, | ||
| 'bottom-and-left': { | ||
| 'mud-popover-bottom-left': 'mud-popover-top-right', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| 'mud-popover-bottom-left': 'mud-popover-top-right', | |
| "mud-popover-bottom-left"': 'mud-popover-top-right', |
| }, | ||
| 'left': { | ||
| 'mud-popover-top-left': 'mud-popover-top-right', | ||
| 'mud-popover-center-left': 'mud-popover-center-right', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| 'mud-popover-center-left': 'mud-popover-center-right', | |
| "mud-popover-center-left"': 'mud-popover-center-right', |
| selector = 'right'; | ||
| } | ||
| } | ||
| else if (classList.contains('mud-popover-bottom-left')) { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| else if (classList.contains('mud-popover-bottom-left')) { | |
| else if (classList.contains"mud-popover-bottom-left"')) { |
| 'top': { | ||
| 'mud-popover-top-left': 'mud-popover-bottom-left', | ||
| 'mud-popover-top-center': 'mud-popover-bottom-center', | ||
| 'mud-popover-top-right': 'mud-popover-bottom-right', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| 'mud-popover-top-right': 'mud-popover-bottom-right', | |
| "mud-popover-top-right"': 'mud-popover-bottom-right', |
| } else if (deltaBottom < gracePeriod) { | ||
| selector = 'top'; | ||
| } else if (deltaToRight < gracePeriod) { | ||
| selector = 'left'; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Strings must use doublequote.
| selector = 'left'; | |
| selector ="left"'; |
There was a small error that was left unaddressed. The method
GetComponentLinkwas to only create links prefixed withcomponents/but in the case where the logicif(parent.Component is not null)was false it would prefix the link withapi/. This issue was corrected and thelinkproperty was used rather than thenameproperty.Description
How Has This Been Tested?
Visually tested.
Types of changes
Checklist:
dev).