Dialog: reverting regression by #3252. Issue #3701 #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3752 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 332 332
Lines 10509 10509
=======================================
Hits 9520 9520
Misses 989 989
Continue to review full report at Codecov.
|
|
@peerpalo, Looks like your test is working now with my little change ;) |
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
…udBlazor#3752) * Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701 * Dialog test: trying to get it to work on CI
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
…udBlazor#3752) * Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701 * Dialog test: trying to get it to work on CI
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
…udBlazor#3752) * Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701 * Dialog test: trying to get it to work on CI
jammerware
pushed a commit
to jammerware/MudBlazor
that referenced
this pull request
Sep 20, 2022
…udBlazor#3752) * Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701 * Dialog test: trying to get it to work on CI
3dots
pushed a commit
to 3dots/MudBlazor
that referenced
this pull request
Mar 23, 2023
…udBlazor#3752) * Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701 * Dialog test: trying to get it to work on CI
ferraridavide
pushed a commit
to ferraridavide/MudBlazor
that referenced
this pull request
May 30, 2023
…udBlazor#3752) * Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701 * Dialog test: trying to get it to work on CI
ilovepilav
pushed a commit
to ilovepilav/MudBlazor
that referenced
this pull request
Nov 25, 2023
…udBlazor#3752) * Dialog: reverting regression by MudBlazor#3252. Issue MudBlazor#3701 * Dialog test: trying to get it to work on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert regression by PR #3252
Fixes #3701
The intended improvement by #3252 will have to be implemented differently, I don't know yet what exactly the problem is/was that prompted the code change.