Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix osx non releasebuilds #35

Merged
merged 5 commits into from
Dec 2, 2017
Merged

Fix osx non releasebuilds #35

merged 5 commits into from
Dec 2, 2017

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Dec 2, 2017

$IDENTITY was blank and this the grep was succeeding - but given that there was no identity, signing was not successful.

@vadi2 vadi2 requested a review from keneanung December 2, 2017 10:40
@vadi2 vadi2 mentioned this pull request Dec 2, 2017
Merged
keneanung
keneanung approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@keneanung keneanung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vadi2 vadi2 merged commit b031a03 into master Dec 2, 2017
@vadi2 vadi2 deleted the fix-osx-non-releasebuilds branch December 2, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keneanung keneanung keneanung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadi2 @keneanung