Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-vari distance calculation #467

Merged
merged 11 commits into from
Jun 6, 2023
Merged

Add multi-vari distance calculation #467

merged 11 commits into from
Jun 6, 2023

Conversation

evanna00
Copy link
Contributor

@evanna00 evanna00 commented Feb 15, 2023 •
edited
Loading

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • docs/changelog.md is updated

Description of changes

Calculate the multi-vary distance and specify the outliers.

Related Issues

Issue #433

@evanna00 evanna00 changed the title Dividing the outlierson trend-plot Dividing the outliers on trend-plot Feb 15, 2023
@multimeric
Copy link
Collaborator

multimeric commented Feb 15, 2023 •
edited
Loading

  • We already had outlier detection previously. The change you made is more broad than that. Please update the title/description accordingly.
  • Please follow the checklist above and ensure you've completed all those things, including adding a test! I can help you with this
  • Make sure the GitHub actions CI is building correctly

multimeric
multimeric requested changes Feb 15, 2023
View reviewed changes
megaqc/rest_api/plot.py Outdated

# Calculate the critical value
n, p = y.shape
cri = f.isf(0.05, dfn=p, dfd=n - p)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here explaining what you are doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculate the line of critical value for the distribution.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but some more detail would be good explain the statistics being used here. You might want to refer to: https://online.stat.psu.edu/stat505/lesson/7/7.1/7.1.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Hotelling’s T-Square to test the statistic for the F distribution.

megaqc/rest_api/plot.py Outdated Show resolved Hide resolved
megaqc/rest_api/plot.py Outdated Show resolved Hide resolved
@evanna00 evanna00 closed this Feb 15, 2023
@evanna00 evanna00 deleted the plot_outliers branch February 15, 2023 02:02
@evanna00 evanna00 changed the title Dividing the outliers on trend-plot Updating the trend-plot Feb 15, 2023
@evanna00 evanna00 restored the plot_outliers branch February 15, 2023 02:13
@evanna00 evanna00 reopened this Feb 15, 2023
@evanna00 evanna00 changed the title Updating the trend-plot Add multi-vari distance calculation Feb 21, 2023
@multimeric multimeric merged commit 1aa40da into MultiQC:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multimeric multimeric Awaiting requested review from multimeric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanna00 @multimeric