Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastp: Improve detection of JSON files #2334

Merged
merged 4 commits into from Feb 15, 2024

Conversation

adamrtalbot
Copy link
Contributor

Increases number of scanned lines for FASTP files to 5 so it doesn't miss the target string anymore.

Fixes #2333

  • This comment contains a description of changes (with reason)

@ewels ewels changed the title Improve detection of FASTP JSON files Fastp: Improve detection of JSON files Feb 15, 2024
@ewels
Copy link
Member

ewels commented Feb 15, 2024

@multiqc-bot changelog

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

multiqc/utils/search_patterns.yaml Outdated Show resolved Hide resolved
@ewels ewels merged commit 2d7f0af into MultiQC:main Feb 15, 2024
3 checks passed
@adamrtalbot adamrtalbot deleted the fastp_paired_end_file_fix branch February 15, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FASTP misses paired end JSON files
4 participants