Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picard CorsscheckFingerprints: support multiple files #2454

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

vladsavelyev
Copy link
Member

Do not override when reading multiple files.

Do not sort samples in heatmap, this way the order is preserved and multiple files are visible on the heatmap.

Fixes #2449

@vladsavelyev vladsavelyev added the bug: module Bug in a MultiQC module label Mar 21, 2024
@vladsavelyev vladsavelyev added this to the MultiQC v1.22: Pydantic milestone Mar 21, 2024
@matthdsm
Copy link
Contributor

Thanks for the quick fix!

Just tested this and it looks awesome! 😄
Do you have an ETA on a release with this fix in it?

PS: I think I've got another bug report ready to go, but I'm still working out if it's actually a bug or not 😅

@vladsavelyev
Copy link
Member Author

Do you have an ETA on a release with this fix in it?

Not really, unfortunately. If it were me, I'd make it next week. But we have another project where I will be needed full time so the release might happen in a month or later.

@vladsavelyev vladsavelyev merged commit 811979c into main Mar 21, 2024
6 checks passed
@vladsavelyev vladsavelyev deleted the crosscheck branch March 21, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

picard Crosscheckfingerprints overwrites results
2 participants