-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas prebuilt #160
Canvas prebuilt #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! 🚀
package.json
Outdated
"mocha-chrome": "1.1.0", | ||
"nyc": "13.1.0", | ||
"uglify-js": "3.4.9", | ||
"unexpected": "10.39.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you switching to exact version numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Not intentionally
test/histogram.js
Outdated
@@ -33,6 +33,7 @@ describe('Histogram of gradient.png', function () { | |||
|
|||
it('should be greyscale', function (done) { | |||
histogram(path, function (error, result) { | |||
expect(error, 'to be', null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: 'to be falsy'
90ec6de
to
cbfa428
Compare
Interesting. I added the jpeg and gif tests to ensure that we could also drop those dependencies on The added tests, which show up green on this PR, fail on my machine :/
|
Updating from node 8.9.x to 8.12, clearing node modules and reinstalling fixed that problem |
I'm sufficiently satisfied that there are no regressions. I'll merge it and do a patch release. Then have a look at the corresponding change in assetgraph-sprite |
Released in v3.0.1 |
Switched to canvas-prebuilt and did a lot of maintenance.
@papandreou This might be a way to remove the
cairo
dependency in assetgraph-sprite as well