Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support skins with a second layer #7

Merged
merged 3 commits into from
Jan 27, 2018
Merged

Conversation

CortexPE
Copy link
Contributor

@CortexPE CortexPE commented Jan 4, 2018

Title says it all 😉

@Muqsit
Copy link
Owner

Muqsit commented Jan 4, 2018

But what's the logic behind it any why another y-loop?
The rgbToTextFormat() is heavy already, this could take a long time to process now that there are two 2-dimensional loops calling functions heavily.

@legoboy0215
Copy link

I agree. There is no point of another y-loop.

@Thunder33345
Copy link

like if there's front use the front and skip the background?

@CortexPE
Copy link
Contributor Author

CortexPE commented Jan 4, 2018

Is it better now?

~ Be back tomorrow.

@Muqsit Muqsit merged commit 07b0564 into Muqsit:master Jan 27, 2018
@lDavidMC lDavidMC mentioned this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants