Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pocketmine dependencies from tebex/api #6

Closed
Muqsit opened this issue Dec 8, 2020 · 1 comment
Closed

Remove pocketmine dependencies from tebex/api #6

Muqsit opened this issue Dec 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Muqsit
Copy link
Owner

Muqsit commented Dec 8, 2020

tebex/api must contain only the raw Tebex API requests and responses and code must only read the responses (and not manipulate it in any way). Any code which wishes to do so must come under tebex/handler, and methods such as TebexCommand::asOnlineFormattedString should be removed as they aren't really a part of the API that Tebex offers, but rather a result of manipulation of API responses.
This will also make the task of extracting tebex/api into a separate library/virion easier.
@Muqsit Muqsit added the enhancement New feature or request label Dec 8, 2020
Muqsit added a commit that referenced this issue Apr 12, 2021
@Muqsit
Address #6
8dcc677
Muqsit added a commit that referenced this issue Apr 12, 2021
@Muqsit
Restructure tebex\thread and tebex\api in favour of #6
fbd01da
Muqsit added a commit that referenced this issue May 21, 2021
@Muqsit
Remove pmmp Server and Logger dependency from tebex\api, introduce si…
18d1f29 
…mple implementations of TebexConnection and TebexApi to address #6
@Muqsit
Copy link
Owner Author

Muqsit commented May 21, 2021

233339f

@Muqsit Muqsit closed this as completed May 21, 2021
@HomeTreeBE HomeTreeBE mentioned this issue Apr 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Muqsit