Blocked radius for warzone #5
Conversation
| /** @var int */ | ||
| private $radius; | ||
|
|
||
| public function __construct(int $min, int $max, int $center, int $radius){ |
There was a problem hiding this comment.
Do you understand what a closed interval is in mathematics? It literally makes no sense for a closed interval to be having a center and radius properties. 🤔
https://en.wikipedia.org/wiki/Interval_(mathematics)#Terminology
There was a problem hiding this comment.
Would moving the center and blocked "radius" (not even sure what to call it) values to the Random2DCoordinateGenerator make more sense? I'm not sure how to go with this.
I mainly wanted to block an inner x by x area from the /wild and reserve it as a warzone people can't /wild into.
There was a problem hiding this comment.
Random2DCoordinateGenerator serves it's use of generating a random 2D point, it need not do anything more than what's it named for.
A better approach would be to abstract the generation code so other plugins can interfere.
Blocking specific regions isn't something Wilderness should be equipped with. It must be something a region managing plugin should inject — not all regions are rectangular.
This pull request adds support for a configurable blocked center area that can be used for blocking a warzone players are not meant to /wild into.