Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Slips - Adjust form templates #2063

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Mar 24, 2024

Uses simplified thumbnail panels for "current"/"last" with buttons to use them, and deletes some unnecessary divs, etc.

Order of links:

  • New: Create, Keep, Use Last
  • Edit: Keep, Use Last, Create

The "keep" and "use last" panels will display side by side if both exist, or just one if there's only one.

screen_shot_2024-03-24_at_3 57 38_pm

Please give this a spin and feel free to merge (into njw-field-slips) if you like it, or let me know about button placement.

@nimmolo nimmolo marked this pull request as ready for review March 24, 2024 21:53
@nimmolo nimmolo changed the title Adjust form templates, use simplified matrix boxes for "current"/"last" Field Slips - Adjust form templates Mar 24, 2024
@nimmolo nimmolo mentioned this pull request Mar 24, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 24, 2024

Coverage Status

coverage: 94.394%. remained the same
when pulling ba3b56e on nimmo-field_slip-templates
into 87c26c0 on njw-field-slips.

Make header/footer more flexible
@mo-nathan
Copy link
Member

I like this faciility for other pages, but I don't think we want to add this much complexity to the Record Field Slip page and we really want "Create New Observation" to be the most obvious choice so new users don't get confused/distracted. If anything, I'd rather the "Use Last Observation" was more hidden so only power users would know it's there.

@nimmolo
Copy link
Contributor Author

nimmolo commented Mar 24, 2024

Revised with simpler panel, no matrix_box

@mo-nathan mo-nathan merged commit 246e7d4 into njw-field-slips Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants