Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to Show Name Version #2069

Merged
merged 7 commits into from
Mar 27, 2024
Merged

Add notes to Show Name Version #2069

merged 7 commits into from
Mar 27, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Mar 26, 2024

Igor requested more info on the Show Name Version page. #2066

It should be possible to reuse partials from show_name, if that template has everything we want (which it should by definition). The "notes" are the only versioned info I could tell that's missing. (what else, maybe lifeform?)

Screen Shot 2024-03-26 at 2 41 05 PM

@nimmolo nimmolo requested a review from JoeCohen March 26, 2024 21:09
@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2024

Coverage Status

coverage: 94.4% (+0.006%) from 94.394%
when pulling 8324f96 on show-name-version
into 9e4129c on main.

@nimmolo nimmolo marked this pull request as ready for review March 26, 2024 21:37
Copy link
Member

@JoeCohen JoeCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It looks good.

@nimmolo
Copy link
Contributor Author

nimmolo commented Mar 27, 2024

PR now includes a refactor of the classification and lifeform panels, to make them easier to reuse (but no changes), and of the Versions panel, to make it a proper panel.

Here it is:
Screen Shot 2024-03-26 at 8 50 19 PM

@nimmolo nimmolo merged commit f858cbe into main Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants