Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bin/dev available (but not necessary) to run solid_queue #2125

Merged
merged 1 commit into from
May 2, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented May 2, 2024

This makes the Rails 7 standard script ./bin/dev available, and adds a Procfile.dev with one task that will start solid_queue in dev.

Note

Unlike the Rails 7 default behavior, this MO bin/dev does not start the dev server, because running the server via foreman makes debug unusable. So if someone wanted to start solid_queue locally, they could call rails s in one window, and bin/dev in another.

Admittedly, typing bundle exec rake solid_queue:start is not that much harder than typing ./bin/dev. But the Procfile can potentially have a list of tasks that run when the dev server starts. In the future this is likely what we will want to use to build the SCSS, start redis, action_cable, etc.

The idea of the PR is to make bin/dev an option, and simplify my current branch switching, where these files keep disappearing.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.446%. remained the same
when pulling 7695437 on nimmo-bin-dev
into 40c4cd3 on main.

@nimmolo nimmolo marked this pull request as ready for review May 2, 2024 03:53
@nimmolo nimmolo changed the title Create bin/dev for solidqueue, and for likely future use Make bin/dev available (but not mandatory) for solidqueue, and for other uses May 2, 2024
@nimmolo nimmolo changed the title Make bin/dev available (but not mandatory) for solidqueue, and for other uses Make bin/dev available (but not mandatory) for solidqueue, and other uses May 2, 2024
@nimmolo nimmolo changed the title Make bin/dev available (but not mandatory) for solidqueue, and other uses Make bin/dev available (but not mandatory) for solidqueue and other uses May 2, 2024
@nimmolo nimmolo changed the title Make bin/dev available (but not mandatory) for solidqueue and other uses Make bin/dev available (but not mandatory) for solidqueue May 2, 2024
@nimmolo nimmolo changed the title Make bin/dev available (but not mandatory) for solidqueue Make bin/dev available (but not mandatory) for solid_queue May 2, 2024
@nimmolo nimmolo changed the title Make bin/dev available (but not mandatory) for solid_queue Make bin/dev available (but not necessary) to run solid_queue May 2, 2024
@nimmolo nimmolo merged commit 5cbb901 into main May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants