Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db/initialize.sql to drop/create a cache_development db #2163

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Jun 5, 2024

The MO process for updating a development db snapshot will usually drop all databases, including this third cache_development db, which is necessary for local caching.

The db/initialize.sql script is intended to prepare mysql to import a new db snapshot, but I think without the changes in this PR, people will have to create the cache_development db manually (and grant user mo privileges) every time they update their dev db, in order to use or test Solid Cache.

(Solid Queue uses tables in the main db, so that's handled by a migration.)

The MO process for updating a development db snapshot will usually drop this third db, which is necessary for local caching.

Solid Queue uses tables in the main db, so that's just a migration.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.429%. remained the same
when pulling 3f660ff on update-db-initialize-sql
into de86988 on main.

@nimmolo nimmolo marked this pull request as ready for review June 5, 2024 21:37
@nimmolo nimmolo changed the title Update db/initialize.sql to drop/create a cache_development db Update db/initialize.sql to drop/create a cache_development db Jun 5, 2024
@nimmolo nimmolo merged commit 41fe437 into main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants