New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with wallet keys, cleanup deps #402

Merged

TonyGiorgio merged 1 commit into master from rm-bip32

Apr 24, 2023

Collaborator

benthecarman commented Apr 24, 2023

Fixed the bug where we were generating incorrect keys the on-chain wallet.

Also cleaned up the code around keys:

Remove bip32 crate and use rust-bitcoin's re-export of it
Remove use of unwraps and handle errors
Remove some unnecessary conversions


          Fix bug with wallet keys, cleanup deps

c802f7c

benthecarman added the bug label

benthecarman requested a review from TonyGiorgio

April 24, 2023 18:14

TonyGiorgio approved these changes

View reviewed changes

TonyGiorgio merged commit 4a938a3 into master

TonyGiorgio deleted the rm-bip32 branch

April 24, 2023 19:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug