Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4] multi module oaipmh project #5

Merged
merged 5 commits into from
Oct 29, 2019
Merged

[#4] multi module oaipmh project #5

merged 5 commits into from
Oct 29, 2019

Conversation

yagee-de
Copy link
Member

merged code from ../oaipmh-dataprovider and ../oaipmh-harvester
provide java modules

merged code from ../oaipmh-dataprovider and ../oaipmh-harvester
provide java modules
Copy link
Member

@fluetze fluetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me I do not have the skills to review this

non-modularized jars won't find the implemention without this file
Copy link
Member

@Mewel Mewel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach. Just fast checked it, seems ok from my end.

@yagee-de yagee-de force-pushed the issue-4 branch 2 times, most recently from 87773a6 to 8849b7c Compare October 28, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants