Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBO-284 Added migrate-mods-accessCondition.xsl. Fixed migrate-mods-ge… #383

Conversation

Possommi
Copy link
Collaborator

@Possommi Possommi commented Apr 26, 2024

…nre.xsl. Adopted mods-display.xsl, ubo-solr.xsl to fixed mods:accessCondition elements
UBO-284

…nre.xsl. Adopted mods-display.xsl, ubo-solr.xsl to fixed mods:accessCondition elements
@Possommi Possommi requested review from kkrebs and fluetze April 26, 2024 11:48
@Possommi
Copy link
Collaborator Author

Possommi commented Apr 26, 2024

@kkrebs @fluetze Currently ThUniBib uses 'licences' as classification. Since we have to migrate anyway I suggest migrating license to "mir_licenses".

@Possommi Possommi force-pushed the issues/UBO-284-mods-accessCondition-classID-licenses-is-illegal-xml-with-respect-to-MODS-schema branch from 1183d62 to 9c439a8 Compare April 26, 2024 17:06
@Possommi Possommi requested a review from fluetze April 26, 2024 17:06
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove redundant code, how about

<xsl:template match="mods:accessCondition[@type = 'use and reproduction']/@classid[.='licenses']">
<xsl:attribute name="xlink:href">
<xsl:value-of select="concat($MCR.baseurl,'classifications/licenses#',.)" />
</xsl:attribute>
</xsl:template>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually not working since it does not remove the text node in mods:accessCondition

Copy link
Contributor

@kkrebs kkrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should put all migration steps together in one stylesheet, but this should be a separate task

@kkrebs kkrebs merged commit d0f324d into develop Apr 30, 2024
1 check passed
@kkrebs kkrebs deleted the issues/UBO-284-mods-accessCondition-classID-licenses-is-illegal-xml-with-respect-to-MODS-schema branch April 30, 2024 09:50
kkrebs added a commit that referenced this pull request May 27, 2024
* develop:
  make conference stored field for migration analysis
  Added new publication types for KDSF compliance (#386)
  UBO-328 Allow to provide dropdown dividers in user menu via navigation.xml (#385)
  UBO-327 fixed xpath
  fixed typo
  UBO-327 also delete accidentally imported license information with non..
  UBO-327 Added migration stylesheet migrate-lang-genre-accessCondition.xsl combining migration of mods:genre, mods:languageTerm and mods:accessCondition
  UBO-321 Do not display placeholders in identity picker search result (#377)
  UBO-325 Improve accessibility of result page (#381)
  UBO-284 Added migrate-mods-accessCondition.xsl. Fixed migrate-mods-ge… (#383)
  UBO-326 Added classification importSourceType.xml and adopted import-list.xed to the use of new classification (#382)
  UBO-291 Store mods:genre with authorityURI and valueURI (#342)
  UBO-309 Add rate-limiting URI-Resolver (#365)
  UBO-324 Made generated id's in ubo-dialog.xsl unique (#380)
  UBO-319 Added rfc5646.xml, added migrate-rfc4646-to-rfc5646.xsl, updated <xed:template id="languages"/> to use rfc5646 in import-editor.xed (#375)
  UBO-323 Index corresponding author (#379)
  UBO-322 Display realname (if any) rather than uid of user on profile page (#378)
  UBO-320 Ugrade MCR.user2.LDAP.Mapping.labeledURI.id_gnd.schema to https (#376)
  UBO-317 Add button to copy url to result set to clipboard (#373)
  UBO-318 Read request handler from $RequestURL (#374)
  UBO-316 Made request handler for statistics configurable (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants