Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert large parameter functions to object parameters #298

Closed
HenryNguyen5 opened this issue Oct 17, 2017 · 1 comment
Closed

Convert large parameter functions to object parameters #298

HenryNguyen5 opened this issue Oct 17, 2017 · 1 comment

Comments

@HenryNguyen5
Copy link

For better code maintainability, functions that take a large number of parameters could instead be refactored to take a single object input. This prevents issues with function parameter order causing invalid data being passed, and easier typing via interfaces.
@crptm crptm mentioned this issue Oct 17, 2017
Closed
3 tasks
@HenryNguyen5 HenryNguyen5 changed the title Convert large parameter functions to object paramters Convert large parameter functions to object parameters Oct 23, 2017
@HenryNguyen5
Copy link
Author

This was related to transaction lib taking in a lot of parameters, fixed by #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HenryNguyen5