Support PHP 8 #925
Comments
Merged
JakeQZ
added a commit
that referenced
this issue
Nov 21, 2020
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
JakeQZ
added a commit
that referenced
this issue
Nov 21, 2020
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
JakeQZ
added a commit
that referenced
this issue
Nov 22, 2020
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
|
Duplicate of #916. |
oliverklee
pushed a commit
that referenced
this issue
Nov 22, 2020
This is required to be able to test against PHP 8. However, PHPUnit 9.x requires PHP 7.3, so a different version of PHPUnit is required for different testing environments. The main change here is a step in the GitHub Action to conditionally update PHPUnit via PHIVE for PHP >=7.3. PHIVE does not yet have the ability for conditional installs (see phar-io/phive#295 (comment)) so the script must check the PHP version before running the update. PHIVE has also been added to the tools (self-referencing) as it is not available by default to GitHub Actions. Note: There are warnings from PHPUnit 9.x about use of deprecated `assert` methods (which will be removed in PHPUnit 10.x). However, these don't cause the tests to fail, and the replacement methods are not available in PHPUnit 7.x which is still required to test against PHP 7.1 and 7.2. Part of #925/#926.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Will need
composer.jsonupdating, and changes to the GitHub Action testing matrix. Hopefully that will be all apart from actually making a new release. I believe the beta/RC version can already be used with GitHub Actions.The text was updated successfully, but these errors were encountered: