Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Collect code coverage and add a coverage badge #1160

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[FEATURE] Collect code coverage and add a coverage badge #1160

merged 1 commit into from
Aug 28, 2024

Conversation

oliverklee
Copy link
Contributor

Fixes #1126
Fixes #807

@oliverklee oliverklee added this to the 7.0.0 milestone Jul 17, 2022
@oliverklee oliverklee requested a review from JakeQZ July 17, 2022 12:19
@oliverklee oliverklee self-assigned this Jul 17, 2022
@oliverklee oliverklee marked this pull request as draft July 17, 2022 12:23
@oliverklee oliverklee force-pushed the feature/coverage branch 3 times, most recently from 4c1ce87 to 1fc4ada Compare July 17, 2022 12:27
@oliverklee
Copy link
Contributor Author

I'll still need to change the path to the coverage file: php-coveralls/php-coveralls#251

@oliverklee oliverklee modified the milestones: 7.0.0, 8.0.0 Nov 1, 2022
@oliverklee
Copy link
Contributor Author

Note to myself: https://github.com/CPS-IT/project-builder/pull/500/files

@oliverklee oliverklee force-pushed the feature/coverage branch 2 times, most recently from 30d870d to 1e1f331 Compare August 23, 2024 14:03
@oliverklee oliverklee removed the request for review from JakeQZ August 23, 2024 14:03
@oliverklee oliverklee force-pushed the feature/coverage branch 2 times, most recently from 0337a4c to 004d7eb Compare August 23, 2024 14:07
@oliverklee oliverklee marked this pull request as ready for review August 23, 2024 14:14
@oliverklee oliverklee requested a review from JakeQZ August 23, 2024 14:15
@oliverklee oliverklee force-pushed the feature/coverage branch 4 times, most recently from 08ffa1d to 07d45b6 Compare August 23, 2024 14:24
@oliverklee
Copy link
Contributor Author

oliverklee commented Aug 23, 2024 •
edited
Loading

Note: As far as I understand it, Coveralls requires the coverage job to have been run for the main branch at least once before it will start to post the change to the coverage numbers on PRs.

JakeQZ
JakeQZ reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of this and a few others that still need review. However, I'll need to fetch the PR branch and do a bit of editing to see how it differs from existing sections in jobs. It's a shame that GitHub Actions do not allow code reusability.

@oliverklee
Copy link
Contributor Author

We might actually be able to reuse things after all. I've created #1286 for this. (I'd like to tackle this later once this PR here is merged, though.)

JakeQZ
JakeQZ approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. If there are any issues, we can resolve them later.

.gitignore
@@ -23,6 +23,7 @@ nbproject
/.php_cs.cache
/.php-cs-fixer.cache
/.phpunit.result.cache
/coverage.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like some of these type of files to be squirrelled away in a subdirectory, though that is beyond the scope of this PR.

@JakeQZ JakeQZ merged commit e0a18a2 into main Aug 28, 2024
25 checks passed
@JakeQZ JakeQZ deleted the feature/coverage branch August 28, 2024 01:29
@JakeQZ JakeQZ mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
enhancement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Composer script for PHPUnit coverage report Add coveralls.io integration
2 participants
@oliverklee @JakeQZ