Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another SyntaxWarning where 'is' is used rather than '==' #127

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Fix another SyntaxWarning where 'is' is used rather than '==' #127

merged 1 commit into from
Aug 21, 2020

Conversation

PureTryOut
Copy link
Contributor

@PureTryOut PureTryOut commented Aug 21, 2020

Seems another one slipped in somewhere in the last release.

Without this MR at least Python 3.8 will complain:

/usr/lib/python3.8/site-packages/lingua_franca/lang/format_cs.py:296: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if abs(num) < 1.0 and (result is "mínus " or not result):

Continuation of #112 I guess.

Seems another one slipped in somewhere in the last release
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Aug 21, 2020
@ChanceNCounter
Copy link
Contributor

Saw that last night! I was afraid I'd reintroduced it in a feature branch, so there's a sick sort of relief noticing that it's in master.

Nicely done, as always. Will double-check and merge.

@ChanceNCounter ChanceNCounter merged commit 481535b into MycroftAI:master Aug 21, 2020
@PureTryOut PureTryOut deleted the syntaxwarning branch August 21, 2020 21:46
ChanceNCounter pushed a commit to ChanceNCounter/lingua-franca that referenced this pull request Oct 9, 2020
ChanceNCounter pushed a commit to ChanceNCounter/lingua-franca that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants