Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Return if audio is None in listener #1165

Merged
merged 1 commit into from
Oct 17, 2017
Merged

Conversation

MatthewScholefield
Copy link
Contributor

This is necessary because if the listener receives a stop signal, it returns None.

@LearnedVector
Copy link
Contributor

LGTM

@LearnedVector LearnedVector merged commit af5f3a8 into dev Oct 17, 2017
@forslund
Copy link
Collaborator

Looks sane, both Queue empty and None will result in the same outcome.

I see one issue I didn't see before. you need to specify timeout=0.5 in self.queue.get() (timeout is the second argument)

so it should be self.queue.get(timeout=0.5)

I had constant lockups when testing and this fixed it, it's a wonder that it have worked as well as it has.

@MatthewScholefield MatthewScholefield deleted the bugfix/listener-reload branch October 17, 2017 19:52
@forslund
Copy link
Collaborator

Ok I'll send a PR with that change then

@LearnedVector
Copy link
Contributor

oh shoot

@penrods penrods added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants