Cleanup of core.py #1835
Merged
Cleanup of core.py #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new simple_trace() function can now generate a simplified stack trace instead of doing it inline in the MycroftSkill class
The most notable things: - Use the new wait flag when calling speak - Fix except without defined exception
forslund
added
Type: Refactoring and other improvements
|
Hello @forslund! Thanks for submitting the PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
exceptnonlocalin get_scheduled_event_status()simple_trace()get_handler_name()How to test
Check that mycroft works normally
Contributor license agreement signed?
CLA [ Yes ]